Skip to content

fix for 1.21.93 and fixed README.md #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix for 1.21.93 and fixed README.md #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
84f8be2
fix for 1.21.93
DaisukeDaisuke Jul 15, 2025
263e5eb
update README.md
DaisukeDaisuke Jul 15, 2025
b141597
This is not a plugin
DaisukeDaisuke Jul 16, 2025
83a984b
fixed //
DaisukeDaisuke Jul 16, 2025
aa948f8
Useless changes
DaisukeDaisuke Aug 5, 2025
28e04ed
ai too bad
DaisukeDaisuke Aug 6, 2025
5b2a79b
Fix code style
DaisukeDaisuke Aug 6, 2025
509d6b9
Fix code style
DaisukeDaisuke Aug 6, 2025
bbf364b
Fix code style
DaisukeDaisuke Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/muqsit/libcamera/CameraInstruction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public static function set(
?Vector3 $facing_pos = null
) : self{
$preset_id = libcamera::getPresetRegistry()->network_ids[spl_object_id($preset)];
$instruction = new CameraSetInstruction($preset_id, $ease, $camera_pos, $rot, $facing_pos, null, null, null);
$instruction = new CameraSetInstruction($preset_id, $ease, $camera_pos, $rot, $facing_pos, null, null, null, false);
return new self([[$instruction, null, null, null]]);
}

Expand Down
14 changes: 6 additions & 8 deletions src/muqsit/libcamera/libcamera.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ public static function isRegistered(): bool{
public static function register(Plugin $plugin) : void{
!self::$registered || throw new BadMethodCallException("Tried to registered an already existing libcamera instance");
$preset_registry = new CameraPresetRegistry([
"free" => new CameraPreset("minecraft:free", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_CAMERA, false, false, null),
"first_person" => new CameraPreset("minecraft:first_person", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_PLAYER, false, false, null),
"third_person" => new CameraPreset("minecraft:third_person", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_PLAYER, false, false, null),
"third_person_front" => new CameraPreset("minecraft:third_person_front", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_PLAYER, false, false, null),
"target" => new CameraPreset("minecraft:target", "minecraft:free", null, null, null, null, null, 0.0, true, new Vector2(0.0, 360.0), new Vector2(0.0, 180.0), true, 50.0, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_CAMERA, false, false, null)
"free" => new CameraPreset("minecraft:free", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_CAMERA, false, null, null),
"first_person" => new CameraPreset("minecraft:first_person", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_PLAYER, false, null, null),
"third_person" => new CameraPreset("minecraft:third_person", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_PLAYER, false, null, null),
"third_person_front" => new CameraPreset("minecraft:third_person_front", "", null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_PLAYER, false, null, null),
"target" => new CameraPreset("minecraft:target", "minecraft:free", null, null, null, null, null, 0.0, true, new Vector2(0.0, 360.0), new Vector2(0.0, 180.0), true, 50.0, null, null, null, null, null, CameraPreset::AUDIO_LISTENER_TYPE_CAMERA, false, null, null)
]);
$packet = CameraPresetsPacket::create(array_values($preset_registry->registered));
Server::getInstance()->getPluginManager()->registerEvent(DataPacketReceiveEvent::class, function(DataPacketReceiveEvent $event) use($packet) : void{
Expand All @@ -48,9 +48,7 @@ public static function register(Plugin $plugin) : void{
foreach($event->getPackets() as $packet){
if($packet instanceof StartGamePacket){
$experiments = $packet->levelSettings->experiments->getExperiments();
$experiments["focus_target_camera"] = true;
$experiments["third_person_cameras"] = true;
$experiments["cameras"] = true;
$experiments["experimental_creator_camera"] = true;//It seems to work without it.
$packet->levelSettings->experiments = new Experiments($experiments, true);
}
}
Expand Down