fix for 1.21.93 and fixed README.md #2
Conversation
|
API improvements etc. are done in a separate branch https://github.com/DaisukeDaisuke/libcamera/tree/readme |
README.md
Outdated
| (float)20.0, //pitch | ||
| (float)180.0 //yaw | ||
| (float)$player->getLocation()->getPitch(), //pitch | ||
| (float)$player->getLocation()->getYaw() //yaw |
There was a problem hiding this comment.
This angle can be chosen freely as far as i know, it sets the direction it's facing - we don't necessarily want to face the same way the player does
plugin.yml
Outdated
There was a problem hiding this comment.
As stated before, this is not a plugin
|
Absolutely no clue what i clicked and how to revert it, my bad, this new UI is just confusing |
|
Already mentioned in the other PR - Too many changes at once, too much bloat, and unnecessary long code blocks in the README. You are basically embedding whole plugins in the README - code blocks in the README are there for giving an understanding of the functionality and usage of methods and APIs, and how to achieve the desired result, not to spoon feed and overwhelm users. |
|
I had made them because leaving code that does not actually work in 1.21.93 would waste users’ time, but it seems a scale-down is now necessary. At the very least, the readme in this PR should be brought to a quality suitable for merging through scaling down |
|
I made the code changes as minimal as possible |
2 participants
Fixed #1