Skip to content

Conversation

lightpohl
Copy link

Hello!

A little new to this, but this is a continuation of the discussion in #41. I was able to get the tests running, and I added a simple test to show that it works and doesn't affect the other tests.

Credit to @balping for the code changes. 👏

Let me know if I need to change anything!

P.S. Thanks for putting a module like this together. 😺

fixes #40

@balping
Copy link
Contributor

balping commented Aug 14, 2018

👍

How do you run npm test? I still get

Uncaught AssertionError: expected [Error: ENOENT: no such file or directory, open '/tmp/string-replace-loader/test/build/build.js'] to equal null

@lightpohl
Copy link
Author

Not quite sure what issue you're running into. Might be an environment problem?

These are the steps I followed to run the tests initially:

  1. git clone https://github.com/lightpohl/string-replace-loader.git
  2. cd string-replace-loader
  3. npm install
  4. npm run test

@balping
Copy link
Contributor

balping commented Aug 14, 2018

I used yarn before, now I used npm and it works. I have no clue why the test doesn't work with yarn.

@lightpohl
Copy link
Author

@Va1 - Let me know if you need any changes or assistance. Happy to help! 😃

@itmayziii
Copy link

Can we please get this merged, the original PR in #41 has been open since march. I would be happy to help in any way if there is something blocking.

Thank you for the library!

@gitgrimbo
Copy link

Hi, can this change be released?

@lightpohl
Copy link
Author

lightpohl commented Sep 23, 2018

For those who are interested, I went ahead and published the forked version with support for replacement callbacks to npm under my scope. Feel free to use it until the feature is available officially! 😃

@lightpohl
Copy link
Author

Hello! Just a quick FYI: going to close down this PR due to inactivity. I'll leave the forked version up on npm, but I've marked it as deprecated.

@lightpohl lightpohl closed this Apr 11, 2019
@Va1
Copy link
Owner

Va1 commented Jun 13, 2019

supported as of 2.2.0. thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: callbacks

5 participants