Replacement callbacks

[balping]

#40

I realised that String.prototype.replace() already has the capability of using callbacks, so only the option validation had to be modified.

I would normally add a test, but I couldn't set up testing. It needs a certain test/build/build.js file that I have no idea how to generate.

[Va1]

hi @balping

you can run tests by executing npm test

what i see is that your code might not work due to the fact that webpack is serializing options to JSON and back and therefore any callbacks will be lost. try it yourself and add tests to PR if it works, i might be wrong

thank you

[balping]

Yes, I can run npm test, but all tests fail, because the lack of the build directory.

Uncaught AssertionError: expected [Error: ENOENT: no such file or directory, open '/tmp/string-replace-loader/test/build/build.js'] to equal null

[balping]

@Va1 bump

[CyberNika]

when will this be released?

[lightpohl]

@Va1 - Hello! Tested these changes locally and they appear to be working well in our app. We’re altering the string replacement depending on the build environment.

Anything I can do to help with this change?

[balping]

@joshuapohl

You could help to figure it out, how to run npm test

[fregante]

I hope to see this landing at some point