Skip to content

feat: upgrading authentication package fixing switching profile issues #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

feat: upgrading authentication package fixing switching profile issues #920

merged 2 commits into from
Jul 17, 2025

Conversation

@fernando-cortez
Copy link
Contributor

@fernando-cortez fernando-cortez commented Jul 16, 2025 •
edited
Loading

Description

This PR upgrades the Authentication package, as a follow-up to the upgrade PR here. Switching profile issues are addressed in this version.

Issue Number(s)

N/A

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ N/A ] JIRA ticket ID is in the PR title or at least one commit message
  • [ N/A ] Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review July 16, 2025 18:47
@fernando-cortez fernando-cortez requested a review from a team as a code owner July 16, 2025 18:47
Elfi0Kuhndorf
Elfi0Kuhndorf approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed seems to fix the issue :D lets see if it comes up in the playtest next week, if not we can definitely close the bug ticket.

kalmanbalint
kalmanbalint approved these changes Jul 17, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fernando-cortez fernando-cortez merged commit 7c81a83 into develop Jul 17, 2025
16 checks passed
@fernando-cortez fernando-cortez deleted the feat/upgrade-authentication branch July 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalmanbalint kalmanbalint kalmanbalint approved these changes

+1 more reviewer

@Elfi0Kuhndorf Elfi0Kuhndorf Elfi0Kuhndorf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fernando-cortez @Elfi0Kuhndorf @kalmanbalint