Skip to content

Conversation

@fernando-cortez
Copy link
Contributor

Description

This PR upgrades the project to the latest LTS, Multiplayer SDK, and Netcode for GameObjects releases.
A cleanup pass was done to the project's assembly definitions.

Issue Number(s)

N/A

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review July 8, 2025 15:37
@fernando-cortez fernando-cortez requested a review from a team as a code owner July 8, 2025 15:37
@Elfi0Kuhndorf
Copy link
Contributor

Elfi0Kuhndorf commented Jul 10, 2025

So I assume the upgrade of Boss Room to Unity 6.1 will come with a different release? Or are we only upgrading to 6.3 LTS probably?

@Elfi0Kuhndorf
Copy link
Contributor

I unfortunately have an error when changing the profile and then trying to join an existing session. It is preventing me from joining the session.

image
[Multiplayer]: Failed to connect to lobby events. Exception Message: There was an error when trying to connect to the lobby service for events. Ensure a valid Lobby ID was sent. Error Code[23007].
UnityEngine.Logger:LogError (string,object)
Unity.Services.Multiplayer.Logger:LogError (object) (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Multiplayer/Utils/Logger.cs:17)
Unity.Services.Multiplayer.LobbyHandler/<SubscribeToLobbyEventsAsync>d__95:MoveNext () (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Multiplayer/Lobby/LobbyHandler.cs:804)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1<Unity.Services.Lobbies.ILobbyEvents>:SetException (System.Exception)
Unity.Services.Lobbies.Internal.WrappedLobbyService/<SubscribeToLobbyEventsAsync>d__11:MoveNext () (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Lobbies/SDK/WrappedLobbyService.cs:115)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder:SetException (System.Exception)
Unity.Services.Lobbies.Internal.LobbyChannel/<SubscribeAsync>d__12:MoveNext () (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Lobbies/SDK/LobbyUpdates/Internal/LobbyChannel.cs:66)
System.Threading.Tasks.TaskCompletionSource`1<bool>:SetException (System.Exception)
Unity.Services.Wire.Internal.Client/<>c__DisplayClass47_0/<<CreateChannel>b__1>d:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:696)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder:SetException (System.Exception)
Unity.Services.Wire.Internal.Client/<SubscribeAsync>d__46:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:660)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1<Unity.Services.Wire.Protocol.Internal.Reply>:SetException (System.Exception)
Unity.Services.Wire.Internal.Client/<SendCommandAsync>d__27:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:149)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1<Unity.Services.Wire.Protocol.Internal.Reply>:SetException (System.Exception)
Unity.Services.Wire.Internal.CommandManager/<WaitForCommandAsync>d__6:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/CommandManager.cs:66)
System.Threading.Tasks.TaskCompletionSource`1<Unity.Services.Wire.Protocol.Internal.Reply>:TrySetException (System.Exception)
Unity.Services.Wire.Internal.CommandManager:OnCommandReplyReceived (Unity.Services.Wire.Protocol.Internal.Reply) (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/CommandManager.cs:86)
Unity.Services.Wire.Internal.Client:HandleCommandReply (Unity.Services.Wire.Protocol.Internal.Reply) (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:611)
Unity.Services.Wire.Internal.Client:OnWebsocketMessage (byte[]) (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:344)
Unity.Services.Wire.Internal.Client/<>c__DisplayClass53_0:<WebsocketMessageListener>b__0 () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:753)
UnityEngine.UnitySynchronizationContext:ExecuteTasks ()

@Elfi0Kuhndorf
Copy link
Contributor

I assume the other PR will fix the error above, but we need to verify that after merging both : )

Elfi0Kuhndorf
Elfi0Kuhndorf previously approved these changes Jul 10, 2025
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe we should mention the other package upgrades in the changelog as well (e.g. postprocessing and input system)?

@fernando-cortez
Copy link
Contributor Author

I unfortunately have an error when changing the profile and then trying to join an existing session. It is preventing me from joining the session.

image ``` [Multiplayer]: Failed to connect to lobby events. Exception Message: There was an error when trying to connect to the lobby service for events. Ensure a valid Lobby ID was sent. Error Code[23007]. UnityEngine.Logger:LogError (string,object) Unity.Services.Multiplayer.Logger:LogError (object) (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Multiplayer/Utils/Logger.cs:17) Unity.Services.Multiplayer.LobbyHandler/d__95:MoveNext () (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Multiplayer/Lobby/LobbyHandler.cs:804) System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetException (System.Exception) Unity.Services.Lobbies.Internal.WrappedLobbyService/d__11:MoveNext () (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Lobbies/SDK/WrappedLobbyService.cs:115) System.Runtime.CompilerServices.AsyncTaskMethodBuilder:SetException (System.Exception) Unity.Services.Lobbies.Internal.LobbyChannel/d__12:MoveNext () (at ./Library/PackageCache/com.unity.services.multiplayer@1719b68380e6/Runtime/Lobbies/SDK/LobbyUpdates/Internal/LobbyChannel.cs:66) System.Threading.Tasks.TaskCompletionSource`1:SetException (System.Exception) Unity.Services.Wire.Internal.Client/<>c__DisplayClass47_0/<b__1>d:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:696) System.Runtime.CompilerServices.AsyncTaskMethodBuilder:SetException (System.Exception) Unity.Services.Wire.Internal.Client/d__46:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:660) System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetException (System.Exception) Unity.Services.Wire.Internal.Client/d__27:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:149) System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:SetException (System.Exception) Unity.Services.Wire.Internal.CommandManager/d__6:MoveNext () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/CommandManager.cs:66) System.Threading.Tasks.TaskCompletionSource`1:TrySetException (System.Exception) Unity.Services.Wire.Internal.CommandManager:OnCommandReplyReceived (Unity.Services.Wire.Protocol.Internal.Reply) (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/CommandManager.cs:86) Unity.Services.Wire.Internal.Client:HandleCommandReply (Unity.Services.Wire.Protocol.Internal.Reply) (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:611) Unity.Services.Wire.Internal.Client:OnWebsocketMessage (byte[]) (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:344) Unity.Services.Wire.Internal.Client/<>c__DisplayClass53_0:b__0 () (at ./Library/PackageCache/com.unity.services.wire@2d36cce58c62/Runtime/Centrifuge/Client.cs:753) UnityEngine.UnitySynchronizationContext:ExecuteTasks () ```

I couldn't reproduce with the latest changes!

@Elfi0Kuhndorf
Copy link
Contributor

Elfi0Kuhndorf commented Jul 11, 2025

I am unfortunately still getting it even with the other PR merged in :/
Reproduction:

  1. switch profile. create lobby
  2. swtich profile, join existing lobby
    repeat switching profile and joining with 2 or 3 players and eventually the error pops up
image

@fernando-cortez
Copy link
Contributor Author

I am unfortunately still getting it even with the other PR merged in :/ Reproduction:

  1. switch profile. create lobby
  2. swtich profile, join existing lobby
    repeat switching profile and joining with 2 or 3 players and eventually the error pops up
image

Hmm I'm trying those same steps and can't reproduce. Could it be that you're signing in on a clone to an account that's already in the lobby? I'm creating a new profile every time.
But, in the meantime, since this isn't game code at the moment, let's have this PR go through with the upgrade and create a ticket for that issue with repro steps.

@Elfi0Kuhndorf
Copy link
Contributor

I changed profile every time, not necessarily creating a new one but switching to an unused existing one. But yeah let's merge it, I will try to reproduce it again after and create a ticket out of it.

@fernando-cortez fernando-cortez merged commit 98f7e73 into develop Jul 14, 2025
16 checks passed
@fernando-cortez fernando-cortez deleted the feat/editor-sdk-ngo-update branch July 14, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants