Skip to content

fix: NullReferenceException caused when unsubscribing on session removal [MTTB-1161] #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: v2.3.0 release
merged 2 commits into from
Apr 2, 2025
Merged

fix: NullReferenceException caused when unsubscribing on session removal [MTTB-1161] #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c8ffac
moving unsubscription to when session not null
fernando-cortez Apr 1, 2025
ab13b7e
changelog addition
fernando-cortez Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Assets/Scripts/UnityServices/Sessions/MultiplayerServicesFacade.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public void BeginTracking()
if (!m_IsTracking)
{
m_IsTracking = true;
SubscribeToJoinedSessionAsync();
SubscribeToJoinedSession();
}
}

Expand All @@ -91,11 +91,11 @@ public void EndTracking()
if (m_IsTracking)
{
m_IsTracking = false;
UnsubscribeFromJoinedSessionAsync();
}

if (CurrentUnitySession != null)
{
UnsubscribeFromJoinedSession();
if (m_LocalUser.IsHost)
{
DeleteSessionAsync();
Expand Down Expand Up @@ -232,7 +232,7 @@ void ResetSession()
// no need to disconnect Netcode, it should already be handled by Netcode's callback to disconnect
}

void SubscribeToJoinedSessionAsync()
void SubscribeToJoinedSession()
{
CurrentUnitySession.Changed += OnSessionChanged;
CurrentUnitySession.StateChanged += OnSessionStateChanged;
Expand All @@ -244,7 +244,7 @@ void SubscribeToJoinedSessionAsync()
CurrentUnitySession.SessionPropertiesChanged += OnSessionPropertiesChanged;
}

void UnsubscribeFromJoinedSessionAsync()
void UnsubscribeFromJoinedSession()
{
CurrentUnitySession.Changed -= OnSessionChanged;
CurrentUnitySession.StateChanged -= OnSessionStateChanged;
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
* Changed the way MeleeAction selects a target when there are multiple targets to collide with. The target with the highest GetTotalDamage value (mentioned above) will be selected.
* Fixed a visual issue where a selected party member's party HUD slot would be displayed as selected (green) when the same or new party member joins the session in-game (#899)
* Fixed Render Graph API compatibility mode warning and switched active input handling settings to "both" for removing InvalidOperationException (#901)
* Fixed error logged when unsubscribing from Session events when removed from a Session (#905)

## [2.5.0] - 2024-04-18

Expand Down