Skip to content

fix: NullReferenceException caused when unsubscribing on session removal [MTTB-1161] #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v2.3.0 release
merged 2 commits into from
Apr 2, 2025
Merged

fix: NullReferenceException caused when unsubscribing on session removal [MTTB-1161] #905

merged 2 commits into from
Apr 2, 2025

Conversation

@fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Apr 1, 2025 •
edited
Loading

Description

Fixing a small error logged when a client is removed from a Session.

Issue Number(s)

MTT-1161

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review April 1, 2025 23:35
@fernando-cortez fernando-cortez requested a review from a team as a code owner April 1, 2025 23:35
@sentinel-u3d sentinel-u3d bot requested a review from Elfi0Kuhndorf April 2, 2025 11:20
Elfi0Kuhndorf
Elfi0Kuhndorf reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error seems to have disappeared

Elfi0Kuhndorf
Elfi0Kuhndorf approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fernando-cortez fernando-cortez merged commit a7dab56 into develop Apr 2, 2025
13 checks passed
@fernando-cortez fernando-cortez deleted the fix/error-on-session-removal branch April 2, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Elfi0Kuhndorf Elfi0Kuhndorf Elfi0Kuhndorf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fernando-cortez @Elfi0Kuhndorf