Skip to content

feat: upgrade project to NGO v1.6.0 [MTT-6875] #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 30, 2023
Merged

feat: upgrade project to NGO v1.6.0 [MTT-6875] #865

merged 6 commits into from
Aug 30, 2023

Conversation

@fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Aug 25, 2023 •
edited
Loading

Description

PR to upgrade the project to NGO v1.6.0
In the process an Version Define has been created for NGO versions 1.5.2 & 1.6.0 and a singular test has been blocked out for these versions.
An upcoming NGO upgrade will address failing Shutdown-related tests.

Issue Number(s)

MTT-6875

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. DO NOT MERGE Do not merge this PR! labels Aug 25, 2023
@fernando-cortez fernando-cortez marked this pull request as ready for review August 28, 2023 19:05
@fernando-cortez fernando-cortez requested a review from a team as a code owner August 28, 2023 19:05
@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers and removed 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. DO NOT MERGE Do not merge this PR! labels Aug 28, 2023
LPLafontaineB
LPLafontaineB reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@LPLafontaineB LPLafontaineB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also include toggling off the Generate Default Network Prefabs List parameter in the project settings now that it is available

LPLafontaineB
LPLafontaineB reviewed Aug 28, 2023
View reviewed changes
@fernando-cortez
Copy link
Collaborator Author

Should also include toggling off the Generate Default Network Prefabs List parameter in the project settings now that it is available

It's been mentioned as a part of this release. Or is there something else to mention?

@LPLafontaineB
Copy link
Contributor

LPLafontaineB commented Aug 30, 2023 •
edited
Loading

Should also include toggling off the Generate Default Network Prefabs List parameter in the project settings now that it is available

It's been mentioned as a part of this release. Or is there something else to mention?

Edit: Nevermind the setting has been pushed already in a previous PR, I did not notice it

@fernando-cortez fernando-cortez merged commit c661768 into develop Aug 30, 2023
@fernando-cortez fernando-cortez deleted the feat/upgrade-to-NGO-v1.6.0 branch August 30, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fernando-cortez @LPLafontaineB