Skip to content

Fix: Negative Collider Warning [MTT-6993] #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v2.3.0 release
merged 3 commits into from
Aug 14, 2023
Merged

Fix: Negative Collider Warning [MTT-6993] #854

merged 3 commits into from
Aug 14, 2023

Conversation

@jilfranco-unity
Copy link
Contributor

@jilfranco-unity jilfranco-unity commented Aug 10, 2023 •
edited
Loading

Description

Changed the colliders on the two diagonal wall assets to not have negative scale.

Issue Number(s)

MTT-6993

Contribution checklist

  • [n/a] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [n/a] An Index entry has been added in readme.md if applicable

@jilfranco-unity jilfranco-unity added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers type:bug Bug Report labels Aug 10, 2023
@jilfranco-unity jilfranco-unity requested a review from a team as a code owner August 10, 2023 18:13
fernando-cortez
fernando-cortez previously approved these changes Aug 11, 2023
View reviewed changes
@fernando-cortez fernando-cortez self-assigned this Aug 11, 2023
fernando-cortez
fernando-cortez approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jilfranco-unity jilfranco-unity merged commit a54d556 into develop Aug 14, 2023
@jilfranco-unity jilfranco-unity deleted the fix/negative-collider-fix branch August 14, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Assignees

@fernando-cortez fernando-cortez

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly type:bug Bug Report

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jilfranco-unity @fernando-cortez