Skip to content

Conversation

@jdepuy
Copy link
Contributor

@jdepuy jdepuy commented Apr 1, 2021

To lessen the compile time of S_SimpleDissolve shader. The shader has been temporarily simplified to an additive shader. The corresponding FX that use this shader have been altered so they don't look broken. Obviously, these FX do not exactly match their original implementations and were altered to best match what they looked like when they were using the S_SimpleDissolve shader. For 'DEVELOP' we will try to introduce an optimized version of the S_SimpleDissolve shader and restore the FX to their original glory :-)

The FX mentioned above are:

  • FX_Boss_Charge_Motion (Flash part)
  • FX_Boss_Defeat
  • FX_Boss_Leap_Ground pound
  • FX_caster_skill_2
  • FX_Torch_Fire!
  • FX_IMP_bomb_impact_big
  • FX_RogueSkill2_loop
  • FX_Fall_down_smoke
  • FX_Ice_Appear
  • FX_Ice_Break
  • FX_run_smoke
  • FX_TankSkill2_idle

@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Apr 1, 2021
@pdeschain
Copy link
Contributor

image
Proof of the fix

@pdeschain pdeschain added the 2-One More Review One review in, one to go label Apr 1, 2021
@SamuelBellomo SamuelBellomo merged commit a6dde6c into release/v0.1.0-experimental Apr 1, 2021
@SamuelBellomo SamuelBellomo deleted the jdp_shadertempfix branch April 1, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 2-One More Review One review in, one to go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants