-
Notifications
You must be signed in to change notification settings - Fork 136
[MTT-8881] Integrate proximity voice-chat #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hammerlerobi
merged 49 commits into
develop
from
feat/distributed-authority-sample/vivox-integration-voicechat
Dec 4, 2024
Merged
Changes from 37 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
bb8dfa0
recreation of vivox scripts from old PR
Elfi0Kuhndorf 99c892d
updating ServiceHelper to join channel
Elfi0Kuhndorf b40e0aa
wip: Enable Vivox, voice and text working somehow without UI atm
hammerlerobi 62e236b
wip: textchat working
hammerlerobi a130940
feat: improve Chat
hammerlerobi 0f5dba5
wip: Improve TextChat
hammerlerobi e0c12fb
wip: achitectural changes
hammerlerobi a865c81
wip: small improvements
hammerlerobi 996ae1b
chore: decouple TextChat from Services
hammerlerobi ee013f9
chore: cleanup
hammerlerobi a1436bf
feat: Block Player Input on Chat Input focused
hammerlerobi 0a6bc49
fix: await Vivox Login
hammerlerobi d62afb4
chore: remove unused files
hammerlerobi caaa3bf
chore: remove scene
hammerlerobi d6e40eb
fix: focus state on textfield
hammerlerobi 1d8170c
fix: improve initialization and handle session leave
hammerlerobi 0a0d12c
chore: cleanup
hammerlerobi f4e064e
wip: Add positional voice chat
hammerlerobi 19680a2
chore: improve architecture
hammerlerobi 661280b
chore: add icon
hammerlerobi 49128af
fix: apply review changes
hammerlerobi 1fcc5db
feat: seperate voice and textchat
hammerlerobi 6beb415
Merge branch 'feat/distributed-authority-sample/vivox-integration-upd…
hammerlerobi 03ffd6a
fix: catching some potential null refs
hammerlerobi 2999565
Merge branch 'develop' into feat/distributed-authority-sample/vivox-i…
hammerlerobi 3b242ca
feat: select audio device wip
hammerlerobi 6a3b54e
fix: add missing UI
hammerlerobi 331348b
feat: Make sure to ask for Microphone permissions on MacOS
hammerlerobi 20743e6
wip: VoiceChat feature complete. Needs cleanup
hammerlerobi b25c4c5
fix: Focus issue
hammerlerobi 066a1ad
chore: cleanup extract fields etc.
hammerlerobi cdeff4c
Merge branch 'develop' into feat/distributed-authority-sample/vivox-i…
hammerlerobi b52e9bc
fix: vivox joining and leaving working
hammerlerobi a04fc81
chore: remove unnecessary code, attach to device change events
hammerlerobi 36fc36a
docs: Update changelog
hammerlerobi 7ecd74d
chore: final cleanup
hammerlerobi e46216b
fix: Hide UI because of Vivox bug
hammerlerobi 2777114
chore: internalize method
hammerlerobi 8fc9b00
chore: remove buildprofile
hammerlerobi 00a7b8a
chore: Move permission check before login
hammerlerobi 5e46a9d
chore: change subscription to events
hammerlerobi 7631e17
chore: remove UI dependency in VivoxManager
hammerlerobi 2caffea
Merge branch 'develop' into feat/distributed-authority-sample/vivox-i…
hammerlerobi b79642b
chore: remove unnecessary argument
hammerlerobi e4f69ef
chore: cleanup ingameMenu
hammerlerobi 271ce2b
fix: reapply VivoxPosition Component
hammerlerobi 9bfa7e7
fix: Make sure base is called
hammerlerobi 622d937
chore: remove unsubscription
hammerlerobi ba5ab5a
chore: wrap everything related to mic permission into define
hammerlerobi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
Basic/DistributedAuthoritySocialHub/Assets/Scripts/Services/Vivox3DPositioning.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| using UnityEngine; | ||
| using Unity.Netcode; | ||
| using Unity.Multiplayer.Samples.SocialHub.GameManagement; | ||
|
|
||
| namespace Unity.Multiplayer.Samples.SocialHub.Services | ||
| { | ||
| class Vivox3DPositioning : NetworkBehaviour | ||
| { | ||
| bool m_Initialized; | ||
| float m_NextPosUpdate; | ||
|
|
||
| void Start() | ||
| { | ||
| GameplayEventHandler.OnChatIsReady -= OnChatIsReady; | ||
| GameplayEventHandler.OnChatIsReady += OnChatIsReady; | ||
|
|
||
| GameplayEventHandler.OnExitedSession -= OnExitSession; | ||
| GameplayEventHandler.OnExitedSession += OnExitSession; | ||
| } | ||
fernando-cortez marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| void OnChatIsReady(bool chatIsReady, string channelName) | ||
| { | ||
| m_Initialized = chatIsReady; | ||
| } | ||
|
|
||
| void OnExitSession() | ||
| { | ||
| m_Initialized = false; | ||
| } | ||
|
|
||
| void Update() | ||
| { | ||
| if (IsOwner && m_Initialized) | ||
| { | ||
| if (Time.time > m_NextPosUpdate) | ||
| { | ||
| VivoxManager.Instance.SetPlayer3DPosition(gameObject); | ||
| m_NextPosUpdate = Time.time + 0.3f; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public override void OnDestroy() | ||
| { | ||
| GameplayEventHandler.OnChatIsReady -= OnChatIsReady; | ||
| GameplayEventHandler.OnExitedSession -= OnExitSession; | ||
| } | ||
| } | ||
| } | ||
3 changes: 3 additions & 0 deletions
3
Basic/DistributedAuthoritySocialHub/Assets/Scripts/Services/Vivox3DPositioning.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.