[SERV-126] Allow audiowaveform processes to exit #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmatney
requested review from
a team,
DRickard and
ksclarke
and removed request for
a team
ksclarke
approved these changes
Jun 19, 2021
DRickard
approved these changes
Jun 21, 2021
angelahuqing
added a commit
that referenced
this pull request
Mar 17, 2023
# This is the 1st commit message: SERV-505 Added jobsQueue to watcherVerticle # This is the commit message #2: [SERV-505] Addition of JobsQueue Class and Test # This is the commit message #3: [SERV-505] Consistency update to CsvItemTest.java # This is the commit message #4: [SERV-505] Cleaned up JobsQueue code # This is the commit message #5: [SERV-505] Completion of JobsQueue functionality and added to WatcherVerticle # This is the commit message #6: [SERV-505] Added in messages # This is the commit message #7: [SERV-505] Fix checkstyle and delete unnecessary files # This is the commit message #8: [SERV-505] Fixed checkstyle violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running A/V Pairtree in production for the first time, I observed that the
audiowaveformprocesses were getting stuck in the "interruptible sleep" state. I determined that they were simply waiting for I/O to complete (i.e., for their output to be read by the parent process); from the docs:I guess this is why. Interestingly, the automated tests didn't catch this -- anyone have an idea why?
Anyway, I've manually tested this change locally and on our "prod" machine, and can confirm that it actually works now.
Also, the debug logging is a bit more verbose now (stderr provides interesting stats about the audiowaveform conversion).