Add script chaining A/V Pairtree, Metagetter, and Festerize #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRickard
reviewed
May 5, 2021
ksclarke
previously approved these changes
May 6, 2021
|
Want to update the main README to reflect the two-step build process while you're here making changes? |
ksclarke
previously approved these changes
May 6, 2021
DRickard
previously approved these changes
May 6, 2021
|
Other than my review changes above. This looks good. Can't speak for the festerize and jar commands. But I get this gist of what's going on. |
cachemeoutside
previously approved these changes
May 6, 2021
ksclarke
previously approved these changes
May 6, 2021
|
Looks like the first commit wasn't signed? https://github.com/UCLALibrary/av-pairtree/pull/4/commits |
|
yeah, I forgot to set |
|
I'm not sure either, but I'd guess you'll need to rebase/squash locally and force push that before GitHub will let you merge. |
DRickard
previously approved these changes
May 6, 2021
DRickard
approved these changes
May 6, 2021
ksclarke
approved these changes
May 6, 2021
angelahuqing
added a commit
that referenced
this pull request
Mar 17, 2023
# This is the 1st commit message: SERV-505 Added jobsQueue to watcherVerticle # This is the commit message #2: [SERV-505] Addition of JobsQueue Class and Test # This is the commit message #3: [SERV-505] Consistency update to CsvItemTest.java # This is the commit message #4: [SERV-505] Cleaned up JobsQueue code # This is the commit message #5: [SERV-505] Completion of JobsQueue functionality and added to WatcherVerticle # This is the commit message #6: [SERV-505] Added in messages # This is the commit message #7: [SERV-505] Fix checkstyle and delete unnecessary files # This is the commit message #8: [SERV-505] Fixed checkstyle violations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have only tested this on my local so far, since Metagetter and Festerize aren't installed on the machine where A/V Pairtree is. Also note the hard-coded path of the Metagetter JAR on L6. I suspect this will probably have to be changed. Should the path be configured with an env var? I also realize the error checking in this script is pretty minimal; wasn't sure how robust to make it since it sounds like it might be relatively short-lived.