Skip to content

Conversation

@torfjelde
Copy link
Member

Updates Turing.jl to be compatible with TuringLang/DynamicPPL.jl#301.

Tests are passing locally, but need new release of DPPL for tests to pass.

torfjelde and others added 30 commits June 8, 2021 06:22
Co-authored-by: David Widmann <[email protected]>
@yebai yebai requested a review from cpfiffer August 14, 2021 18:32
@torfjelde
Copy link
Member Author

I'll get this merged once DPPL is released and tests pass.

@cpfiffer
Copy link
Member

Oh man I love this. Thumbs up from me!

@coveralls
Copy link

coveralls commented Aug 14, 2021

Pull Request Test Coverage Report for Build 1131092986

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 80.071%

Totals Coverage Status
Change from base Build 1128200924: 0.5%
Covered Lines: 1125
Relevant Lines: 1405

💛 - Coveralls

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #1681 (3c78ff9) into master (d924caf) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
+ Coverage   79.56%   80.07%   +0.50%     
==========================================
  Files          23       23              
  Lines        1414     1405       -9     
==========================================
  Hits         1125     1125              
+ Misses        289      280       -9     
Impacted Files Coverage Δ
src/modes/ModeEstimation.jl 91.07% <100.00%> (+6.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d924caf...3c78ff9. Read the comment docs.

@yebai yebai merged commit b277b01 into master Aug 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the tor/dppl-update branch August 14, 2021 21:30
@yebai
Copy link
Member

yebai commented Aug 14, 2021

Thanks, @torfjelde - excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants