Skip to content

Conversation

@torfjelde
Copy link
Member

This PR introduces condition and decondition. This is really just a reopening of #294 that I can't reopen directly due to the target branch now being deleted.

torfjelde and others added 30 commits July 15, 2021 20:08
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@torfjelde
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 13, 2021
@torfjelde
Copy link
Member Author

torfjelde commented Aug 13, 2021

Even though tests will pass, this will break the implementation of contexts in Turing.jl since contextual_isassumption and matchinvalue will require an implementation of NodeTrait which OptimizationContext does not.

In fact, this might be broken on the current release 😕

EDIT: Seems like it's not an issue one the current branch, but IntegrationTests breaks on this branch.

@bors
Copy link
Contributor

bors bot commented Aug 13, 2021

try

Build failed:

@torfjelde
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 13, 2021
@bors
Copy link
Contributor

bors bot commented Aug 13, 2021

try

Build failed:

@torfjelde
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 14, 2021
@bors
Copy link
Contributor

bors bot commented Aug 14, 2021

try

Build failed:

@torfjelde
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 14, 2021
@yebai
Copy link
Member

yebai commented Aug 14, 2021

Bors r+

@bors
Copy link
Contributor

bors bot commented Aug 14, 2021

👎 Rejected by too few approved reviews

@yebai
Copy link
Member

yebai commented Aug 14, 2021

Bors r+

bors bot pushed a commit that referenced this pull request Aug 14, 2021
This PR introduces `condition` and `decondition`. This is really just a reopening of #294 that I can't reopen directly due to the target branch now being deleted.

Co-authored-by: Hong Ge <[email protected]>
@bors bors bot changed the title condition and decondition [Merged by Bors] - condition and decondition Aug 14, 2021
@bors bors bot closed this Aug 14, 2021
@bors bors bot deleted the tor/conditioning-with-traits-in-model branch August 14, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants