Skip to content

Use tape based Libtask #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 3, 2022
Merged

Use tape based Libtask #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4f28c4c
use tape based Libtask
Dec 7, 2021
eb8600f
code refactor
Dec 7, 2021
d9a7740
use new CTask constructor
Dec 10, 2021
b4c43d1
Update Project.toml
yebai Dec 12, 2021
2f83b03
Update Project.toml
yebai Dec 12, 2021
9d7debf
use TapeInstruction
Dec 15, 2021
83e6a34
remove useless code
Dec 15, 2021
dd4bfac
Update src/model.jl
yebai Jan 31, 2022
2b0b9cd
Apply suggestions from code review
yebai Jan 31, 2022
9088efc
Fix format
devmotion Jan 31, 2022
ed1afe1
Update src/container.jl
yebai Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ StatsFuns = "4c63d2b9-4356-54db-8cca-17b64c39e42c"
[compat]
AbstractMCMC = "2, 3"
Distributions = "0.23, 0.24, 0.25"
Libtask = "0.5.3"
Libtask = "0.6"
Random123 = "1.3"
StatsFuns = "0.9"
julia = "1.3"
16 changes: 2 additions & 14 deletions src/container.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,7 @@ end
const Particle = Trace

function Trace(f, rng::TracedRNG)
ctask = let f = f
Libtask.CTask() do
res = f(rng)
Libtask.produce(nothing)
return res
end
end
ctask = Libtask.CTask(f, rng)

# add backward reference
newtrace = Trace(f, ctask, rng)
Expand Down Expand Up @@ -62,13 +56,7 @@ function forkr(trace::Trace)
newf = reset_model(trace.f)
Random123.set_counter!(trace.rng, 1)

ctask = let f = trace.ctask.task.code
Libtask.CTask() do
res = f()(trace.rng)
Libtask.produce(nothing)
return res
end
end
ctask = Libtask.CTask(newf, trace.rng)

# add backward reference
newtrace = Trace(newf, ctask, trace.rng)
Expand Down
4 changes: 2 additions & 2 deletions test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
[compat]
AbstractMCMC = "2, 3"
Distributions = "0.24, 0.25"
Libtask = "0.5"
Libtask = "0.6"
julia = "1.3"
Random123 = "1.3"
Random123 = "1.3"