Skip to content

Conversation

@KDr2
Copy link
Member

@KDr2 KDr2 commented Dec 7, 2021

Run test cases against the tape-based libtask.

We don't support branches in taped libtask now, so I commented out one test case which contains a if expression.

All other test cases passed.

@devmotion
Copy link
Member

I think it would be good to make a release of AdvancedPS 0.3 first, update Turing, and add integration tests here. There are many unreleased changes on the master branch of AdvancedPS and it is not clear how well they work with Turing and what changes are needed there. I think it would be better to update the ecosystem in two steps, to avoid mixing up problems or introducing any regressions in the Libtask rewrite (still think it would be better to use a new package 😄).

@KDr2
Copy link
Member Author

KDr2 commented Dec 7, 2021

still think it would be better to use a new package 😄

I have the same thought, but I am focusing on making sure this approach works now and haven't got any concrete update plans :)

@yebai
Copy link
Member

yebai commented Dec 9, 2021

I think it would be good to release AdvancedPS 0.3 first, update Turing, and add integration tests here. There are many unreleased changes on the master branch of AdvancedPS and it is not clear how well they work with Turing and what changes are needed there.

How about we first make a new release based on the most recent release, but with changes in this PR? This would allow us to support Julia 1.7 first. I think new changes on the master branch and in #32 will likely take more time to push through.

I have created a new releases branch from the most recent release. If we merge this PR into the releases brach, we can make a new release there without worrying about the changes on the master branch.

@coveralls
Copy link

coveralls commented Dec 12, 2021

Pull Request Test Coverage Report for Build 1773658267

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 60.197%

Totals Coverage Status
Change from base Build 1467265102: 0.2%
Covered Lines: 245
Relevant Lines: 407

💛 - Coveralls

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #35 (ed1afe1) into master (248d6ea) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   59.95%   60.19%   +0.24%     
==========================================
  Files           6        6              
  Lines         412      407       -5     
==========================================
- Hits          247      245       -2     
+ Misses        165      162       -3     
Impacted Files Coverage Δ
src/container.jl 94.24% <100.00%> (+1.83%) ⬆️
src/model.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248d6ea...ed1afe1. Read the comment docs.

@KDr2
Copy link
Member Author

KDr2 commented Dec 14, 2021

Close in favor of #36.

@KDr2 KDr2 closed this Dec 14, 2021
@KDr2 KDr2 deleted the taped-libtask branch December 14, 2021 09:15
@yebai yebai restored the taped-libtask branch December 14, 2021 14:03
@yebai yebai reopened this Dec 14, 2021
@yebai
Copy link
Member

yebai commented Dec 14, 2021

#36 is a backport to the most recent release, we still need this PR to update the master.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yebai yebai merged commit 44f9fd8 into master Feb 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the taped-libtask branch February 3, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants