-
Notifications
You must be signed in to change notification settings - Fork 12
Use tape based Libtask #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think it would be good to make a release of AdvancedPS 0.3 first, update Turing, and add integration tests here. There are many unreleased changes on the master branch of AdvancedPS and it is not clear how well they work with Turing and what changes are needed there. I think it would be better to update the ecosystem in two steps, to avoid mixing up problems or introducing any regressions in the Libtask rewrite (still think it would be better to use a new package 😄). |
I have the same thought, but I am focusing on making sure this approach works now and haven't got any concrete update plans :) |
How about we first make a new release based on the most recent release, but with changes in this PR? This would allow us to support Julia 1.7 first. I think new changes on the master branch and in #32 will likely take more time to push through. I have created a new releases branch from the most recent release. If we merge this PR into the releases brach, we can make a new release there without worrying about the changes on the master branch. |
Pull Request Test Coverage Report for Build 1773658267Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 59.95% 60.19% +0.24%
==========================================
Files 6 6
Lines 412 407 -5
==========================================
- Hits 247 245 -2
+ Misses 165 162 -3
Continue to review full report at Codecov.
|
|
Close in favor of #36. |
|
#36 is a backport to the most recent release, we still need this PR to update the master. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Run test cases against the tape-based libtask.
We don't support branches in taped libtask now, so I commented out one test case which contains a
ifexpression.All other test cases passed.