Skip to content

Conversation

@mileslucas
Copy link
Contributor

@mileslucas mileslucas commented Apr 10, 2021

Breaking change to isdone signature

fixes #67

@mileslucas mileslucas marked this pull request as draft April 10, 2021 21:51
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #68 (ff5d718) into master (232fb36) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files           6        6           
  Lines         187      187           
=======================================
  Hits          184      184           
  Misses          3        3           
Impacted Files Coverage Δ
src/sample.jl 99.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232fb36...ff5d718. Read the comment docs.

@mileslucas mileslucas marked this pull request as ready for review April 10, 2021 21:55
Co-authored-by: Cameron Pfiffer <[email protected]>
@cpfiffer cpfiffer merged commit 2f6d220 into master Apr 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the ml/isdone branch April 10, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update convergence sampling signature to use state

3 participants