Skip to content

Update convergence sampling signature to use state #67

@mileslucas

Description

@mileslucas

while !isdone(rng, model, sampler, samples, i; progress=progress, kwargs...)

I think this should be updated to be

isdone(rng, model, sampler, samples, state, i; progress=progress, kwargs...)

to coincide with the immutable samplers (#42, #56), which would be breaking (unfortunately).

Thoughts on this? I'm happy to PR, just let me know if this has downstream effects that I'll need to address, too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions