Skip to content

Conversation

@mileslucas
Copy link
Contributor

#56 changed the callback signature but did not update it for the convergence sampling mcmcsample.

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #66 (0a8ae72) into master (d961513) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files           6        6           
  Lines         187      187           
=======================================
  Hits          184      184           
  Misses          3        3           
Impacted Files Coverage Δ
src/sample.jl 99.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d961513...0a8ae72. Read the comment docs.

@devmotion
Copy link
Member

Can you update the version number (it should be a bugfix release) and add some tests?

@mileslucas mileslucas requested a review from devmotion April 10, 2021 20:53
@mileslucas mileslucas merged commit 232fb36 into master Apr 10, 2021
@mileslucas mileslucas deleted the ml/callback branch April 10, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants