Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/client/src/widgets/buttons/note_actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export default class NoteActionsWidget extends NoteContextAwareWidget {

this.$convertNoteIntoAttachmentButton.toggle(note.isEligibleForConversionToAttachment());

this.toggleDisabled(this.$findInTextButton, ["text", "code", "book"].includes(note.type));
this.toggleDisabled(this.$findInTextButton, ["text", "code", "book", "mindMap"].includes(note.type));

this.toggleDisabled(this.$showAttachmentsButton, !isInOptions);
this.toggleDisabled(this.$showSourceButton, ["text", "code", "relationMap", "mermaid", "canvas", "mindMap", "geoMap"].includes(note.type));
Expand Down
6 changes: 4 additions & 2 deletions apps/client/src/widgets/find.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export default class FindWidget extends NoteContextAwareWidget {
return;
}

if (!["text", "code", "render"].includes(this.note?.type ?? "")) {
if (!["text", "code", "render", "mindMap"].includes(this.note?.type ?? "")) {
return;
}

Expand Down Expand Up @@ -250,6 +250,8 @@ export default class FindWidget extends NoteContextAwareWidget {
case "text":
const readOnly = await this.noteContext?.isReadOnly();
return readOnly ? this.htmlHandler : this.textHandler;
case "mindMap":
return this.htmlHandler;
default:
console.warn("FindWidget: Unsupported note type for find widget", this.note?.type);
}
Expand Down Expand Up @@ -352,7 +354,7 @@ export default class FindWidget extends NoteContextAwareWidget {
}

isEnabled() {
return super.isEnabled() && ["text", "code", "render"].includes(this.note?.type ?? "");
return super.isEnabled() && ["text", "code", "render", "mindMap"].includes(this.note?.type ?? "");
}

async entitiesReloadedEvent({ loadResults }: EventData<"entitiesReloaded">) {
Expand Down
2 changes: 1 addition & 1 deletion apps/client/src/widgets/find_in_html.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default class FindInHtml {
if (this.$results?.length) {
const $current = this.$results.eq(this.currentIndex);
this.$results.removeClass(FIND_RESULT_SELECTED_CSS_CLASSNAME);
$current[0].scrollIntoView();
$current[0].scrollIntoView({ block: 'center', inline: 'center'});
$current.addClass(FIND_RESULT_SELECTED_CSS_CLASSNAME);
}
}
Expand Down
9 changes: 9 additions & 0 deletions apps/client/src/widgets/type_widgets/mind_map.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,4 +286,13 @@ export default class MindMapWidget extends TypeWidget {
utils.downloadSvgAsPng(this.note.title, svg);
}

async executeWithContentElementEvent({ resolve, ntxId }: EventData<"executeWithContentElement">) {
if (!this.isNoteContext(ntxId)) {
return;
}

await this.initialized;

resolve(this.$content.find('.main-node-container'));
}
}
2 changes: 1 addition & 1 deletion apps/server-e2e/src/layout/tab_bar.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ test("Search works when dismissing a tab", async ({ page, context }) => {

await app.getTab(0).click();
await app.openAndClickNoteActionMenu("Search in note");
await expect(app.findAndReplaceWidget).toBeVisible();
await expect(app.findAndReplaceWidget.first()).toBeVisible();
});

test("New tab displays workspaces", async ({ page, context }) => {
Expand Down
Loading