Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

feat(mindMap): support find #2055

Merged
merged 2 commits into from
May 30, 2025
Merged

feat(mindMap): support find #2055

merged 2 commits into from
May 30, 2025

Conversation

@SiriusXT
Copy link
Member

图片

@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

Folder/File Previous size New size Difference
/upload/TriliumNextNotes-Server-2055-merge-linux-x64.tar.xz 66.71MB +66.71MB (+100.00%)
TOTAL +66.71MB

eliandoran
eliandoran approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job doing it so fast!

@eliandoran
Copy link
Contributor

Seems one of the tests is failing: "Search works when dismissing a tab"

Could you have a look?

@SiriusXT
Copy link
Member Author

Seems one of the tests is failing: "Search works when dismissing a tab"

Could you have a look?

Ok, I’ll take care of it tomorrow.

@SiriusXT SiriusXT marked this pull request as draft May 29, 2025 16:06
@SiriusXT SiriusXT marked this pull request as ready for review May 30, 2025 02:48
@SiriusXT
Copy link
Member Author

It was caused by supporting mindMap find, which made app.findAndReplaceWidget find two elements and resulted in an error. I have fixed it.

@eliandoran eliandoran merged commit 74a11b5 into develop May 30, 2025
11 checks passed
@eliandoran eliandoran deleted the mind-map-find branch May 30, 2025 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eliandoran eliandoran eliandoran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SiriusXT @eliandoran