Skip to content

Fixed package info for help package and removed NotNull annotations #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Fixed package info for help package and removed NotNull annotations #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8bb806
fixed package info for help package
Taz03 Dec 14, 2022
547fef7
removed notnull annotations
Taz03 Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...on/src/main/java/org/togetherjava/tjbot/commands/bookmarks/LeftoverBookmarksListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import net.dv8tion.jda.api.events.guild.member.GuildMemberJoinEvent;
import net.dv8tion.jda.api.events.guild.member.GuildMemberRemoveEvent;
import net.dv8tion.jda.api.hooks.ListenerAdapter;
import org.jetbrains.annotations.NotNull;

import org.togetherjava.tjbot.commands.EventReceiver;

Expand All @@ -25,14 +24,14 @@ public LeftoverBookmarksListener(BookmarksSystem bookmarksSystem) {
}

@Override
public void onGuildMemberRemove(@NotNull GuildMemberRemoveEvent event) {
public void onGuildMemberRemove(GuildMemberRemoveEvent event) {
long userID = event.getUser().getIdLong();

bookmarksSystem.startDeletionPeriodForUser(userID);
}

@Override
public void onGuildMemberJoin(@NotNull GuildMemberJoinEvent event) {
public void onGuildMemberJoin(GuildMemberJoinEvent event) {
long userID = event.getUser().getIdLong();

bookmarksSystem.cancelDeletionPeriodForUser(userID);
Expand Down
4 changes: 1 addition & 3 deletions ...ication/src/main/java/org/togetherjava/tjbot/commands/help/HelpThreadCreatedListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@

import org.togetherjava.tjbot.commands.EventReceiver;

import javax.annotation.Nonnull;

import java.time.Instant;
import java.time.temporal.ChronoUnit;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -41,7 +39,7 @@ public HelpThreadCreatedListener(HelpSystemHelper helper) {
}

@Override
public void onChannelCreate(@Nonnull ChannelCreateEvent createEvent) {
public void onChannelCreate(ChannelCreateEvent createEvent) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u double check other EventReceivers in the code base? Im pretty sure I copied this method from somewhere in the code base. So maybe that other user also has @Nonnull.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh yea there was more

if (!createEvent.getChannelType().isThread()) {
return;
}
Expand Down
5 changes: 3 additions & 2 deletions application/src/main/java/org/togetherjava/tjbot/commands/help/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* This package offers all functionality for the help system. For example commands that let users
* ask questions, such as {@link org.togetherjava.tjbot.commands.help.AskCommand}.
* This package offers all functionality for the help system. For example commands that handles the
* actions taken after creating a help thread
* {@link org.togetherjava.tjbot.commands.help.HelpThreadCreatedListener}.
*/
@MethodsReturnNonnullByDefault
@ParametersAreNonnullByDefault
Expand Down