Fixed package info for help package and removed NotNull annotations #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zabuzard
previously approved these changes
Dec 15, 2022
|
|
||
| @Override | ||
| public void onChannelCreate(@Nonnull ChannelCreateEvent createEvent) { | ||
| public void onChannelCreate(ChannelCreateEvent createEvent) { |
There was a problem hiding this comment.
can u double check other EventReceivers in the code base? Im pretty sure I copied this method from somewhere in the code base. So maybe that other user also has @Nonnull.
Taz03
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Zabuzard
approved these changes
Dec 16, 2022
|
merging today, so that it makes it into the last release for this year, tomorrow :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it points to a class which is not available