Adding tag used in the footer #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lved with adding a parameters to MethodUtils which would provide the tags into the footer for the embeds, also edited the values of 5 classes so they match the parameters for MethodUtils
Zabuzard
requested changes
Dec 9, 2021
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/utils/MessageUtils.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagCommand.java
Outdated
Show resolved
Hide resolved
…he EmbedBuilder instead to the classes as a replacement
Zabuzard
requested changes
Dec 10, 2021
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagsCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagsCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/free/FreeCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/free/FreeCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/free/FreeCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Dec 10, 2021
application/src/main/java/org/togetherjava/tjbot/commands/free/FreeCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
requested changes
Dec 10, 2021
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
Show resolved
Hide resolved
Zabuzard
requested changes
Dec 10, 2021
application/src/main/java/org/togetherjava/tjbot/commands/free/FreeCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
added
priority: normal
enhance command
Zabuzard
requested changes
Dec 10, 2021
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagManageCommand.java
Outdated
Show resolved
Hide resolved
Zabuzard
previously approved these changes
Dec 10, 2021
Zabuzard
requested review from
marko-radosavljevic,
java-coding-prodigy and
Tais993
RealYusufIsmail
previously approved these changes
Dec 10, 2021
|
@IslamSakrak There is a conflict with the Tag Command which is preventing the merge |
You know that GitHub notifies them for that already? No need to tell them again^^ Just review the code as it is right now (it will only slightly change with the conflict resolved anyways). |
auto-merge was automatically disabled
December 11, 2021 08:46
Head branch was pushed to by a user without write access
DevSerendipity
dismissed stale reviews from RealYusufIsmail and Zabuzard
via
2bc4e8a
Zabuzard
requested changes
Dec 11, 2021
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagsCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagsCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/tags/TagsCommand.java
Outdated
Show resolved
Hide resolved
|
I haven't checked this branch for a while, and now when i did review i noticed I was behind on this branch on some commands so that's why the last push has commits I have already pulled, and in the same time I fixed the mistakes you guys have pointed out . 👍 |
Zabuzard
approved these changes
Dec 29, 2021
|
Approval, last code change >7 days ago, Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request on resolving the issue#275
#275
The issue was resolved with adding a parameters to MethodUtils which would provide the tags into the footer for the embeds, also edited the values of 5 classes so they match the parameters for MethodUtils