Adding tag used in the footer #308
Conversation
|
Could you add a screenshot on how it looks like please? Thanks. |
Zabuzard
added
enhance command
| public static @NotNull MessageEmbed generateEmbed(@Nullable String title, | ||
| @NotNull CharSequence content, @Nullable User user, @Nullable Color ambientColor) { | ||
| @NotNull CharSequence content, @Nullable User user, @Nullable Color ambientColor, | ||
| @Nullable String footerTag) { |
There was a problem hiding this comment.
I think this is overly specific. Change the role of footerTag to just a footer. And then move the user.getName() + footerTag logic into the call-site.
So that all callers can now use this parameter as footer and not as "footerTag".
|
Wait stop. This commit history is totally broken. Why does it contain the code from your other PR (#296 ), remove that stuff. You have to develop your features individually, isolated from each other. |
|
Converted to draft to block merging before the git history is cleaned up (i.e. the dependency to #296 is removed). |
Yes. Have a look at the commit history and the changes that this PR introduces. Basically, 8 of your 9 commits should not be here, they are from #296 and should not be in this PR (#308 ): |
well maybe you got it confused those are mine commits not @MaiTheLord , and also I have no idea how these commits entered here, giving that I have only created the branch and pushed the changes on it |
You probably did something wrong when rebasing/pulling develop. In any case, those commits have to go. |
DevSerendipity
force-pushed
the
feature/replicating-slash-command
branch
from
7b13bce to
98d1611
Compare
|
Closed in favor of #309 |
This is a pull request on resolving the issue#275
https://github.com/Together-Java/TJ-Bot/issues/275The issue was resolved with adding a parameters to MethodUtils which would provide the tags into the footer for the embeds, also edited the values of 5 classes so they match the parameters for MethodUtils