Skip to content

Migrated Role Reactions #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 48 commits into from
Closed

Migrated Role Reactions #284

wants to merge 48 commits into from

Conversation

JJeeff248
Copy link
Contributor

@JJeeff248 JJeeff248 commented Nov 28, 2021 •
edited by talentedasian
Loading

This PR adds the /role-select command which allows Moderators to send a message where users can select their own roles much like we currently have in the demand_a_role channel on the server.

This addresses #217 and also implements the suggestion of using selection menus.

So far there are two sub-commands, all and choose.

  • all will list all the available roles for users to select from
  • choose lets the mod select the roles to display

Both sub-commands allow for a title and description which get sent in an embedded message above the selection menu.

image

Things I'm wanting to improve/add:

  • UX design. I was thinking a way to include emotes could be nice.
  • Allow users to deselect roles to remove them

@JJeeff248 JJeeff248 requested review from a team as code owners November 28, 2021 10:13
@JJeeff248 JJeeff248 self-assigned this Nov 28, 2021
@JJeeff248 JJeeff248 linked an issue Nov 28, 2021 that may be closed by this pull request
Migrate the role reactions activity #217
Closed
@Tais993
Copy link
Member

Tais993 commented Nov 28, 2021

Currently this shows who ran the command.
image

Thoughts on sending an ephemeral message to the user ".. went successfull"
And sending an actual message to the channel? This way it doesn't display the command.

@JJeeff248
Copy link
Contributor Author

Thoughts on sending an ephemeral message to the user ".. went successfull"
And sending an actual message to the channel?

I like it, I think this helps keep things looking clean.

Implemented in 9312729.

Now looks like this:
image

@JJeeff248
Copy link
Contributor Author

I realised I should've shown how the different commands look so have some screen shots below.

This is /role-select all

image

This is /role-select choose

image

And this is what happens when you select a role
image

@Zabuzard Zabuzard added this to the Migrate existing commands milestone Nov 29, 2021
@Zabuzard Zabuzard added enhance command Modify or improve an existing command or group of commands of the bot new command Add a new command or group of commands to the bot priority: normal and removed enhance command Modify or improve an existing command or group of commands of the bot labels Nov 29, 2021
Tais993
Tais993 requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@Tais993 Tais993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of my comments, you did a good job 👍

@JJeeff248 JJeeff248 force-pushed the feature/migrate_reaction_roles branch from ea71c0e to 84715e1 Compare November 30, 2021 20:42
@Zabuzard
Copy link
Member

Zabuzard commented Dec 7, 2021

@JJeeff248 Your still on it? Or should someone else take over? :)

@JJeeff248 JJeeff248 force-pushed the feature/migrate_reaction_roles branch from c1d1c80 to ceb516e Compare December 7, 2021 20:52
@JJeeff248
Copy link
Contributor Author

I'm still on it, just been a busy week :)

@JJeeff248 JJeeff248 force-pushed the feature/migrate_reaction_roles branch from ceb516e to 3050425 Compare December 7, 2021 23:33
Tais993
Tais993 reviewed Dec 8, 2021
View reviewed changes
Copy link
Member

@Tais993 Tais993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review, but noticed it so

JJeeff248 and others added 10 commits December 13, 2021 16:23
@JJeeff248
Initial commit of the RoleSelect command
590fb6f
@JJeeff248
Applied spotless check
1c5384e
@JJeeff248
Added check to make sure the user has the right permissions to change…
cdecca8 
… roles
@JJeeff248
Changed the way bot replies
bb7e2eb 
The bot now sends a message with the menu and embed to the channel instead of replying to the even
@JJeeff248
Users can deselect roles to remove them
6f87f03
@JJeeff248 @Tais993
Removed unnecessary Objects#requireNotNull
48b8988 
Co-authored-by: Tais993 <[email protected]>
@JJeeff248
A bit of code clean up
307b62a 
Code clean up using suggestions from Tais993
@JJeeff248
A bit of code clean up
f7cac5b 
Code clean up using suggestions from Tais993
@JJeeff248
Removed unused import
31d8462
@JJeeff248
Renamed variable to make more sense.
d017bc1 
Removed Objects#requiresNotNull as not needed.
Zabuzard and others added 22 commits December 17, 2021 16:55
@Zabuzard @JJeeff248
Cleanup and bugfix with unmodifable list
afd08a8
@Zabuzard @JJeeff248
Removed DatabaseCommand
fd58740
@krankkkk @JJeeff248
Spring Version Update (Together-Java#324)
6894466 
This time really set log4j on 2.16+
@krankkkk @JJeeff248
Create Custom Filter for the AsyncAppender (Together-Java#327)
ebf7498
@Zabuzard @JJeeff248
Addition of stale-workflow
3ec7a99 
* marks issues and PRs after 30 days of inactivity
* then closes after 5 additional days of inactivity
@JJeeff248
Initial commit of the RoleSelect command
e27451f
@JJeeff248
Applied spotless check
41ccb92
@JJeeff248
Added check to make sure the user has the right permissions to change…
848eb43 
… roles
@JJeeff248
Changed the way bot replies
fcff080 
The bot now sends a message with the menu and embed to the channel instead of replying to the even
@JJeeff248
Users can deselect roles to remove them
0f412a9
@JJeeff248 @Tais993
Removed unnecessary Objects#requireNotNull
2b4c3ff 
Co-authored-by: Tais993 <[email protected]>
@JJeeff248
A bit of code clean up
319d13f 
Code clean up using suggestions from Tais993
@JJeeff248
A bit of code clean up
f770046 
Code clean up using suggestions from Tais993
@JJeeff248
Removed unused import
f23c792
@JJeeff248
Renamed variable to make more sense.
6ffd558 
Removed Objects#requiresNotNull as not needed.
@JJeeff248
Tidied up code a bit.
c9a7de9 
Shortened some lines by simplifying the code. Also added some checks to see if a role has been removed from the server.
@JJeeff248 @Tais993
Compressed the makeEmbed method
f5c1e92 
Co-authored-by: Tais993 <[email protected]>
@JJeeff248
Changed log messages to meet Sonar string format standards
ac83a88
@JJeeff248
Spotless Applied
2a9dde9
@JJeeff248
Now complies with SonarLint COGNITIVE COMPLEXITY
0b48812
@JJeeff248
Excludes bot roles from menus
c81eca4
@JJeeff248
Added curley brackets to if statement
27c2d1d
@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jan 16, 2022
@Tais993
Copy link
Member

Tais993 commented Jan 20, 2022

@JJeeff248 do you've time this week or possibly next week to finish this PR, otherwise I (or maybe someone else) could finish it

@github-actions github-actions bot removed the stale label Jan 21, 2022
@JJeeff248
Copy link
Contributor Author

Sorry I've been inactive. I wont have much free time to finish off this command for awhile unfortunately. I am happy for someone else to take over and finish it up :)

@Tais993
Copy link
Member

Tais993 commented Jan 23, 2022

Will take over ^^

@Tais993 Tais993 closed this Jan 23, 2022
@Tais993 Tais993 mentioned this pull request Jan 23, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Heatmanofurioso Heatmanofurioso Heatmanofurioso left review comments

@marko-radosavljevic marko-radosavljevic marko-radosavljevic left review comments

@Tais993 Tais993 Tais993 requested changes

Assignees

@JJeeff248 JJeeff248

Labels

new command Add a new command or group of commands to the bot priority: normal

Projects

None yet

Milestone

Migrate existing commands

Development

Successfully merging this pull request may close these issues.

Migrate the role reactions activity

6 participants

@JJeeff248 @Tais993 @Zabuzard @Heatmanofurioso @marko-radosavljevic @krankkkk