Skip to content

Create Custom Filter for the AsyncAppender #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 16, 2021
Merged

Create Custom Filter for the AsyncAppender #327

merged 10 commits into from
Dec 16, 2021

Conversation

krankkkk
Copy link
Contributor

@krankkkk krankkkk commented Dec 14, 2021 •
edited
Loading

Implements One part of the changes for #287
The AsyncAppender is wrapper in an conditional Filter, that only passes the logevents on if an Environment property "TJ_APPENDER" is set.

Note: this means we now also need an compile-time dependency on the log4j2-impl

@krankkkk krankkkk requested review from a team as code owners December 14, 2021 23:18
@Zabuzard Zabuzard added enhancement New feature or request priority: normal labels Dec 15, 2021
@Zabuzard
Copy link
Member

Is this a draft or is it ready already? cause its failing checks.

Zabuzard
Zabuzard requested changes Dec 15, 2021
View reviewed changes
@krankkkk
Copy link
Contributor Author

Apologies was intended as a draft, can now be reviewed,
Checks seem to be failing because gradle on Github-Workers cannot find log4j2, but I cannot replicate the issue locally

@krankkkk krankkkk changed the title Create Custom Appended wrapping the AsyncAppender Create Custom Filter for the AsyncAppender Dec 15, 2021
@krankkkk krankkkk enabled auto-merge (squash) December 15, 2021 21:19
Zabuzard
Zabuzard requested changes Dec 15, 2021
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@krankkkk krankkkk merged commit 3c7cc42 into develop Dec 16, 2021
@Zabuzard Zabuzard deleted the feature/custom_appender branch December 16, 2021 10:55
JJeeff248 pushed a commit to JJeeff248/TJ-Bot that referenced this pull request Dec 17, 2021
@krankkkk @JJeeff248
Create Custom Filter for the AsyncAppender (Together-Java#327)
ebf7498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zabuzard Zabuzard Zabuzard approved these changes

@Tais993 Tais993 Tais993 approved these changes

Assignees

@krankkkk krankkkk

Labels

enhancement New feature or request priority: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krankkkk @Zabuzard @Tais993