Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/reference/useInfiniteQuery.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const {

**Options**

The options for `useInfiniteQuery` are identical to the [`useQuery` hook](../reference/useQuery) with the addition of the following:
The options for `useInfiniteQuery` are identical to the [`useQuery` hook](../reference/useQuery) with the addition of the following and a small difference in `isRefetching`:

- `queryFn: (context: QueryFunctionContext) => Promise<TData>`
- **Required, but only if no default query function has been defined** [`defaultQueryFn`](../guides/default-query-function)
Expand All @@ -39,6 +39,9 @@ The options for `useInfiniteQuery` are identical to the [`useQuery` hook](../ref
- When new data is received for this query, this function receives both the first page of the infinite list of data and the full array of all pages.
- It should return a **single variable** that will be passed as the last optional parameter to your query function.
- Return `undefined` to indicate there is no previous page available.
- `isRefetching: boolean`
- Is `true` whenever a background refetch is in-flight, which _does not_ include initial `loading` or fetching of next or previous page
- Is the same as `isFetching && !isLoading && !isFetchingNextPage && !isFetchingPreviousPage`

**Returns**

Expand Down
19 changes: 13 additions & 6 deletions packages/query-core/src/infiniteQueryObserver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,18 +139,25 @@ export class InfiniteQueryObserver<
): InfiniteQueryObserverResult<TData, TError> {
const { state } = query
const result = super.createResult(query, options)

const { isFetching, isRefetching } = result

const isFetchingNextPage =
isFetching && state.fetchMeta?.fetchMore?.direction === 'forward'

const isFetchingPreviousPage =
isFetching && state.fetchMeta?.fetchMore?.direction === 'backward'

return {
...result,
fetchNextPage: this.fetchNextPage,
fetchPreviousPage: this.fetchPreviousPage,
hasNextPage: hasNextPage(options, state.data?.pages),
hasPreviousPage: hasPreviousPage(options, state.data?.pages),
isFetchingNextPage:
state.fetchStatus === 'fetching' &&
state.fetchMeta?.fetchMore?.direction === 'forward',
isFetchingPreviousPage:
state.fetchStatus === 'fetching' &&
state.fetchMeta?.fetchMore?.direction === 'backward',
isFetchingNextPage,
isFetchingPreviousPage,
isRefetching:
isRefetching && !isFetchingNextPage && !isFetchingPreviousPage,
}
}
}
16 changes: 16 additions & 0 deletions packages/react-query/src/__tests__/useInfiniteQuery.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -516,52 +516,60 @@ describe('useInfiniteQuery', () => {
data: undefined,
isFetching: true,
isFetchingNextPage: false,
isRefetching: false,
})
// Initial fetch done
expect(states[1]).toMatchObject({
data: { pages: [10] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch next page
expect(states[2]).toMatchObject({
data: { pages: [10] },
isFetching: true,
isFetchingNextPage: true,
isRefetching: false,
})
// Fetch next page done
expect(states[3]).toMatchObject({
data: { pages: [10, 11] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch previous page
expect(states[4]).toMatchObject({
data: { pages: [10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: true,
isRefetching: false,
})
// Fetch previous page done
expect(states[5]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
// Refetch
expect(states[6]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: true,
})
// Refetch done
expect(states[7]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
})

Expand Down Expand Up @@ -618,52 +626,60 @@ describe('useInfiniteQuery', () => {
data: undefined,
isFetching: true,
isFetchingNextPage: false,
isRefetching: false,
})
// Initial fetch done
expect(states[1]).toMatchObject({
data: { pages: [10] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch next page
expect(states[2]).toMatchObject({
data: { pages: [10] },
isFetching: true,
isFetchingNextPage: true,
isRefetching: false,
})
// Fetch next page done
expect(states[3]).toMatchObject({
data: { pages: [10, 11] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch previous page
expect(states[4]).toMatchObject({
data: { pages: [10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: true,
isRefetching: false,
})
// Fetch previous page done
expect(states[5]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
// Refetch
expect(states[6]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: true,
})
// Refetch done
expect(states[7]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
})

Expand Down
16 changes: 16 additions & 0 deletions packages/solid-query/src/__tests__/createInfiniteQuery.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -555,52 +555,60 @@ describe('useInfiniteQuery', () => {
data: undefined,
isFetching: true,
isFetchingNextPage: false,
isRefetching: false,
})
// Initial fetch done
expect(states[1]).toMatchObject({
data: { pages: [10] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch next page
expect(states[2]).toMatchObject({
data: { pages: [10] },
isFetching: true,
isFetchingNextPage: true,
isRefetching: false,
})
// Fetch next page done
expect(states[3]).toMatchObject({
data: { pages: [10, 11] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch previous page
expect(states[4]).toMatchObject({
data: { pages: [10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: true,
isRefetching: false,
})
// Fetch previous page done
expect(states[5]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
// Refetch
expect(states[6]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: true,
})
// Refetch done
expect(states[7]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
})

Expand Down Expand Up @@ -661,52 +669,60 @@ describe('useInfiniteQuery', () => {
data: undefined,
isFetching: true,
isFetchingNextPage: false,
isRefetching: false,
})
// Initial fetch done
expect(states[1]).toMatchObject({
data: { pages: [10] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch next page
expect(states[2]).toMatchObject({
data: { pages: [10] },
isFetching: true,
isFetchingNextPage: true,
isRefetching: false,
})
// Fetch next page done
expect(states[3]).toMatchObject({
data: { pages: [10, 11] },
isFetching: false,
isFetchingNextPage: false,
isRefetching: false,
})
// Fetch previous page
expect(states[4]).toMatchObject({
data: { pages: [10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: true,
isRefetching: false,
})
// Fetch previous page done
expect(states[5]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
// Refetch
expect(states[6]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: true,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: true,
})
// Refetch done
expect(states[7]).toMatchObject({
data: { pages: [9, 10, 11] },
isFetching: false,
isFetchingNextPage: false,
isFetchingPreviousPage: false,
isRefetching: false,
})
})

Expand Down