-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Make isRefetching false when fetching next/previous page in an infinite query #4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make isRefetching false when fetching next/previous page in an infinite query #4465
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 57236b2:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. do the existing tests sufficiently cover the different behaviour?
I had to update update few tests to cover |
Codecov ReportBase: 96.36% // Head: 92.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4465 +/- ##
==========================================
- Coverage 96.36% 92.47% -3.89%
==========================================
Files 45 88 +43
Lines 2281 3577 +1296
Branches 640 927 +287
==========================================
+ Hits 2198 3308 +1110
- Misses 80 253 +173
- Partials 3 16 +13 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Dominik Dorfmeister <[email protected]>
Rationale discussed under #3744