Skip to content

fix: remove browser entry, fix umd size #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2022
Merged

fix: remove browser entry, fix umd size #4044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6c91da
fix: remove browser entry, fix umd size
DamianOsipiuk Aug 16, 2022
e676bea
fix: bundle query-core with react-query for umd
DamianOsipiuk Aug 18, 2022
8b092f9
fix: remove missed browser entry
DamianOsipiuk Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/query-async-storage-persister/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
"types": "build/lib/index.d.ts",
"module": "build/lib/index.mjs",
"main": "build/lib/index.js",
"browser": "build/umd/index.production.js",
"types": "build/lib/index.d.ts",
"exports": {
".": {
"types": "./build/lib/index.d.ts",
Expand Down
3 changes: 1 addition & 2 deletions packages/query-broadcast-client-experimental/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
"types": "build/lib/index.d.ts",
"module": "build/lib/index.mjs",
"main": "build/lib/index.js",
"browser": "build/umd/index.production.js",
"types": "build/lib/index.d.ts",
"exports": {
".": {
"types": "./build/lib/index.d.ts",
Expand Down
3 changes: 1 addition & 2 deletions packages/query-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
"types": "build/lib/index.d.ts",
"module": "build/lib/index.mjs",
"main": "build/lib/index.js",
"browser": "build/umd/index.production.js",
"types": "build/lib/index.d.ts",
"exports": {
".": {
"types": "./build/lib/index.d.ts",
Expand Down
3 changes: 1 addition & 2 deletions packages/query-sync-storage-persister/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
"types": "build/lib/index.d.ts",
"module": "build/lib/index.mjs",
"main": "build/lib/index.js",
"browser": "build/umd/index.production.js",
"types": "build/lib/index.d.ts",
"exports": {
".": {
"types": "./build/lib/index.d.ts",
Expand Down
15 changes: 7 additions & 8 deletions packages/react-query-devtools/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,9 @@
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
"types": "build/lib/index.d.ts",
"module": "build/lib/index.mjs",
"main": "build/lib/index.js",
"browser": "build/lib/index.js",
"types": "build/lib/index.d.ts",
"files": [
"build/lib/*",
"build/umd/*",
"cjs.fallback.js",
"src"
],
"exports": {
".": {
"development": {
Expand All @@ -40,6 +33,12 @@
},
"./package.json": "./package.json"
},
"files": [
"build/lib/*",
"build/umd/*",
"cjs.fallback.js",
"src"
],
"scripts": {
"clean": "rm -rf ./build",
"test:eslint": "../../node_modules/.bin/eslint --ext .ts,.tsx ./src"
Expand Down
3 changes: 1 addition & 2 deletions packages/react-query-persist-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
"types": "build/lib/index.d.ts",
"module": "build/lib/index.mjs",
"main": "build/lib/index.js",
"browser": "build/umd/index.production.js",
"types": "build/lib/index.d.ts",
"exports": {
".": {
"types": "./build/lib/index.d.ts",
Expand Down
3 changes: 1 addition & 2 deletions packages/react-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
"type": "github",
"url": "https://github.com/sponsors/tannerlinsley"
},
"types": "build/lib/index.d.ts",
"module": "build/lib/index.mjs",
"main": "build/lib/index.js",
"browser": "build/umd/index.production.js",
"types": "build/lib/index.d.ts",
"exports": {
".": {
"types": "./build/lib/index.d.ts",
Expand Down
11 changes: 10 additions & 1 deletion rollup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,10 @@ export default function rollup(options: RollupOptions): RollupOptions[] {
entryFile: 'src/index.ts',
globals: {
react: 'React',
'react-dom': 'ReactDOM',
'@tanstack/query-core': 'QueryCore',
},
bundleUMDGlobals: ['@tanstack/query-core'],
}),
...buildConfigs({
name: 'react-query-devtools',
Expand Down Expand Up @@ -128,10 +130,17 @@ function buildConfigs(opts: {
outputFile: string
entryFile: string
globals: Record<string, string>
// This option allows to bundle specified dependencies for umd build
bundleUMDGlobals?: string[]
}): RollupOptions[] {
const input = path.resolve(opts.packageDir, opts.entryFile)
const externalDeps = Object.keys(opts.globals)

const bundleUMDGlobals = opts.bundleUMDGlobals || []
const umdExternal = externalDeps.filter(
(external) => !bundleUMDGlobals.includes(external),
)

const external = (moduleName) => externalDeps.includes(moduleName)
const banner = createBanner(opts.name)

Expand All @@ -145,7 +154,7 @@ function buildConfigs(opts: {
globals: opts.globals,
}

return [esm(options), cjs(options), umdDev(options), umdProd(options)]
return [esm(options), cjs(options), umdDev({...options, external: umdExternal}), umdProd({...options, external: umdExternal})]
}

function esm({ input, packageDir, external, banner }: Options): RollupOptions {
Expand Down