fix: remove browser entry, fix umd size

[DamianOsipiuk]

@TkDodo
This should fix:

• some bundlers picking up browser entry in package.json (umd build instead of cjs or esm)
• unusual size of react-query, due to missing rollup global definition for react-dom

This won't fix:

• bundlers that support exports, but does not support development/production conditionals (https://webpack.js.org/guides/package-exports/#optimizations)
  This might be the case as those conditionals were mostly proposed by webpack.
  We could potentially overcome this by linking exports/./default/default not to noop.js, but to intermediate js file that conditionally require devtools based on NODE_ENV, like in the v3.
  This however i would like to test separately.

Previous beta release also have a side effect that react-query UMD build does not contain query-core UMD build and therefore is smaller. Is that something we should fix to be bundled together?

--

I would like to get this as a beta pre-release to test it out.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b092f9:

Sandbox	Source
@tanstack/query-example-react-basic	Configuration
@tanstack/query-example-react-basic-typescript	Configuration

[TkDodo]

I merged main back into beta - there were lots of conflicts. Can you update your PR with beta too please?

[TkDodo]

then I'll make the next beta release. Current release is 4.2.0 - does that make the next beta be 4.3.0-beta.0 ?

[DamianOsipiuk]

then I'll make the next beta release. Current release is 4.2.0 - does that make the next beta be 4.3.0-beta.0 ?

I would say 4.2.2-beta.0, but you can also do 4.3.0-beta.0. It should not matter too much.

[TkDodo]

@DamianOsipiuk I wanted to check the bundle size, but it seems the config is no longer correct:

query/package.json

Lines 120 to 126 in 8025dbf

	"bundlewatch": {
	"files": [
	{
	"path": "packages/**/build/umd/*.production.js"
	}
	]
	}

Not sure where the umd builds are now ? I think we just need to point towards packages/**/build/lib/index.js ?

[DamianOsipiuk]

@TkDodo UMD build files should be in the same place and the config should still work.

[TkDodo]

@DamianOsipiuk yeah I've seen the results, but they look weird, like, why is packages/react-query/build/umd/index.production.js only 2.22 kb?

[DamianOsipiuk]

Previous beta release also have a side effect that react-query UMD build does not contain query-core UMD build and therefore is smaller. Is that something we should fix to be bundled together?

Basically in current rollup setup, if we mark query-core as external to strip it out from cjs and esm builds, it also strips it from umd build. Previously it was not the case.

Therefore if we want to maintain previous way of bundling react-query and query-core together but only for UMD build, rollup config needs to be restructured.

[TkDodo]

ah yes. so in the docs we say that react-query can be installed via:

<script src="https://unpkg.com/@tanstack/react-query@4/build/umd/index.production.js"></script>

this should still work, so we can't really break that

[DamianOsipiuk]

Hmmm, i think that right now you would have to

<script src="https://unpkg.com/@tanstack/query-core@4/build/umd/index.production.js"></script>
<script src="https://unpkg.com/@tanstack/react-query@4/build/umd/index.production.js"></script>

So it is kind of a breaking change unfortunately 😞

I will look at the rollup config, maybe i will come up with some clever override.

[DamianOsipiuk]

@TkDodo Should be good now

[codecov-commenter]

Codecov Report

Merging #4044 (8b092f9) into beta (e0aad73) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             beta    #4044      +/-   ##
==========================================
- Coverage   97.11%   96.82%   -0.30%     
==========================================
  Files          50       57       +7     
  Lines        2391     2673     +282     
  Branches      706      785      +79     
==========================================
+ Hits         2322     2588     +266     
- Misses         67       83      +16     
  Partials        2        2              

Impacted Files	Coverage Δ
src/devtools/devtools.tsx
src/core/notifyManager.ts
src/devtools/theme.tsx
src/core/query.ts
src/reactjs/useQueries.ts
src/reactjs/useIsMutating.ts
src/reactjs/useIsFetching.ts
src/devtools/Logo.tsx
src/createWebStoragePersister/index.ts
src/devtools/utils.ts
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.