Support numpy 2.0 #3640
Merged
Support numpy 2.0 #3640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support_python_3.13
zm711
reviewed
Jan 24, 2025
|
|
||
| dependencies = [ | ||
| "numpy>=1.20, <2.0", # 1.20 np.ptp, 1.26 might be necessary for avoiding pickling errors when numpy >2.0 | ||
| "numpy>=1.20", |
Member
There was a problem hiding this comment.
Are we sure we have enough of pickling tests to feel okay deleting Heberto's note?
Member
Author
There was a problem hiding this comment.
I think so! :) let's see
dhmjhu
added a commit
to regro-cf-autotick-bot/spikeinterface-feedstock
that referenced
this pull request
Feb 11, 2025
For numpy and neo: SpikeInterface/spikeinterface#3640 For zarr: SpikeInterface/spikeinterface#3598
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from @h-mayorquin PR #3481, but one thing at a time.
This is only for numpy 2.0 (with NEO 0.14.0)