-
Couldn't load subscription status.
- Fork 297
refactor setup.py to setup.cfg #4168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just taking a quick initial look here + wanting to make a more general point : |
@pp-mo At his moment in time, not that I know of... but this PR is certainly a step in the right direction IMHO If and when building extensions and custom commands is possible outside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea @bjlittle! Some suggestions for you.
bbf0c72 to
a9c347b
Compare
|
@trexfeathers @jamesp Awesome, thanks! BTW I tested this PR successfully with the following:
|
* master: refactor setup.py to setup.cfg (SciTools#4168) update docs pypi release (SciTools#4173) Update CI environment lockfiles (SciTools#4137) update CONTRIBUTING.md (SciTools#4165) RTD support link update (SciTools#4166) drop py36 support (SciTools#4163) github issues contact link for discussions (SciTools#4164) Bump black version (SciTools#4162) Stop CI from clobbering commits on lockfile updates (SciTools#4157) [pre-commit.ci] pre-commit autoupdate (SciTools#4161) Add a method to return a CubeList from CubeList.copy() (SciTools#4094) Update black et al (SciTools#4155)
🚀 Pull Request
Description
This PR rationalises the
setup.pyinto thesetup.cfg.As a justification for this, see this
setuptoolsadvise on Transitioning from setup.py to setup.cfg and Transitional Note i.e., thesetuptoolsdevs are pushing the community to usesetup.cfgrather thansetup.py.Although, note that a minimal
setup.pyis still required if your project requires to perform apip install --editable, seesetuptoolssetup.cfg-only projects.Note that, we've now unified all the PyPI requirements under
setup.cfgand users have the option to install dependencies as they need i.e.,pip install iris[docs]pip install iris[test]pip install iris[all]pip install iris[docs,test]Consult Iris pull request check list