-
Couldn't load subscription status.
- Fork 297
update black version #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update black version #3866
Conversation
That change is generally quite helpful to a Python yearling like me ❤ |
|
@trexfeathers I suppose this requires a If so, would you prefer me to tack it along with this PR, or raise it separately? |
I hope this will be a quick one, so just include it here. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for persevering @bjlittle 🖌️ ⚫
|
@trexfeathers Awesome, thanks! 👍 |
|
Wow, just wow. 🤯 |
* master: Whatsnew for effects on aux factories of units defaulting to 'unknown'. (SciTools#3870) Whatsnew entry for SciTools#3867. (SciTools#3868) Developer guide overhaul (SciTools#3852) Update CF standard name table to v75 (SciTools#3867) Link to new classes and methods in the Ancillary variables whatsnew. (SciTools#3865) update black version (SciTools#3866) Fix whatsnew api links. (SciTools#3856) Add additional pre-commit hooks (SciTools#3862) update pre-commit flake8 version (SciTools#3863) whatsnew - update announcement (SciTools#3861) whatsnew - remove contents directive (SciTools#3859) whatsnew - links and versions (SciTools#3853) Replace deprecated IndexFormatter (SciTools#3857) whatsnew for SciTools#3681 (SciTools#3858) Whatsnew entry for SciTools#3846. (SciTools#3855) Image tests: set agg backend after rcdefaults (SciTools#3846) whatnew - announcements (SciTools#3850)
🚀 Pull Request
Description
🎬 Take two...
Encountered unexpected minor carnage in #3864, when attempting to upgrade the
blackversion from19.10b0to20.8b1, so it was actually easier to close #3864 and start again 😉Okay, so this was interesting... you could just leave
blackto do it's thing, and mindlessly accept what it generates. However, a wee bit of manual intervention is required in the case whereblackhad previously (19.10b0) injected trailing,'s at the end of sequences et al... which is fine in itself, but when injested by20.8b1it reformats it in a rather hideous way e.g., thisgoes to
🤮
In response, the manual intervention involves deciding whether the previously injected
,was necessary or not, particularly if it was causing icky reformatting to occur.Also, I ended up making acceptable but slightly subtle tuples more explicit, also in order to avoid over-blackification™️ (that's now an official term btw 😉) e.g., this
becomes this
Meh... I'm not overly offended by it, particularly when it stops this
transmuting into this little rose bud
Consult Iris pull request check list