Skip to content

Conversation

@trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

"What's New" entry for #3846.


Consult Iris pull request check list

@rcomer
Copy link
Member

rcomer commented Sep 16, 2020

Oh OK, so when you said every change should have a whatsnew, you really did mean every change!

@rcomer rcomer merged commit 38c7b80 into SciTools:master Sep 16, 2020
@trexfeathers
Copy link
Contributor Author

Oh OK, so when you said every change should have a whatsnew, you really did mean every change!

Feel free to disagree! I'm only comfortable with this because of the Internal heading, and the fact that it's at the bottom. It keeps developers informed more easily than browsing the repo, and helps demonstrate how much work does go in to keep Iris working even if a lot doesn't manifest as a tangible change.

@rcomer
Copy link
Member

rcomer commented Sep 16, 2020

No disagreement in principle, though in this case writing the whatsnew was probably more effort than moving the offending line!

tkknight added a commit to tkknight/iris that referenced this pull request Sep 20, 2020
* master:
  Whatsnew for effects on aux factories of units defaulting to 'unknown'. (SciTools#3870)
  Whatsnew entry for SciTools#3867. (SciTools#3868)
  Developer guide overhaul (SciTools#3852)
  Update CF standard name table to v75 (SciTools#3867)
  Link to new classes and methods in the Ancillary variables whatsnew. (SciTools#3865)
  update black version (SciTools#3866)
  Fix whatsnew api links. (SciTools#3856)
  Add additional pre-commit hooks (SciTools#3862)
  update pre-commit flake8 version (SciTools#3863)
  whatsnew - update announcement (SciTools#3861)
  whatsnew - remove contents directive (SciTools#3859)
  whatsnew - links and versions (SciTools#3853)
  Replace deprecated IndexFormatter (SciTools#3857)
  whatsnew for SciTools#3681 (SciTools#3858)
  Whatsnew entry for SciTools#3846. (SciTools#3855)
  Image tests: set agg backend after rcdefaults (SciTools#3846)
  whatnew - announcements (SciTools#3850)
@trexfeathers trexfeathers deleted the whatsnew_3846 branch February 23, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants