Skip to content

Conversation

@stephenworsley
Copy link
Contributor

@stephenworsley stephenworsley commented Aug 20, 2020

Updating the launch_ancils feature branch to latest master (42a1964)

(Merged using the "Commit merge" to preserve the original)

Contributes to #3473

pp-mo and others added 7 commits December 13, 2019 09:43
* _regrid_area_weighted_array: Tweak variable order to near other use in code (SciTools#3571)

* Fix problems with export and echo command. (SciTools#3577)

* Pushdocs fix2 (SciTools#3580)

* Revert to single-line command for doctr invocation.

* Added script comment, partly to force Github respin.

* Added whatsnew for Black. (SciTools#3581)

* Fixes required due to the release of iris-grib v0.15.0 (SciTools#3582)

* Fix python-eccodes pin in travis (SciTools#3593)

* Netcdf load of ancillary vars: first working.
* Whatsnews relating to ancillary load + save.
* change dependencies : NOTE these changes need removing when remerging to master
[FB] Launch ancils: reset mergebase to commit 738093f
… launch_ancils

* 'launch_ancils' of https://github.com/SciTools/iris:
  Resolve conflicts with requirements/test.txt to update the imagehash pin to imagehash>=4.0 (SciTools#3735)
  PI:3358 (WIP) Ensure flags load/save without units (SciTools#3613)
  PI-3473 Rename "engine.provides" (SciTools#3590)
  PI-3473: Whatsnews relating to ancillary load + save. (SciTools#3557)
  PI-3473: Netcdf loading ancillary variables (SciTools#3556)

� Conflicts:
�	lib/iris/fileformats/netcdf.py
�	lib/iris/tests/unit/fileformats/netcdf/test__load_aux_factory.py
�	requirements/core.txt
@abooton abooton changed the title Launch ancils merged [FB] launch_ancils: Update merge-base to commit 42a1964 Aug 20, 2020
def setUp(self):
standard_name = "atmosphere_hybrid_sigma_pressure_coordinate"
self.requires = dict(formula_type=standard_name)
self.ap = mock.MagicMock(units="units")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is noted that this file conflicted when merged. The resolution is essentially to retain the cube_parts variables in place of provides.
(Is not as a severe conflict than it initially appeared 👍 )

@abooton
Copy link
Contributor

abooton commented Aug 20, 2020

It is noted that when the feature branch was update, there were conflicts in the following files:
requirements/core.txt - resolved by using requirements in master (the pinning in previous commits is no longer required)
lib/iris/tests/unit/fileformats/netcdf/test__load_aux_factory.py - these conflicts are resolved by keeping the "cube_parts".

@abooton abooton merged commit f5a7a83 into SciTools:launch_ancils_mergebase42a1964 Aug 20, 2020
@abooton
Copy link
Contributor

abooton commented Aug 20, 2020

I've now replaced the launch_ancils feature branch with the newly updated launch_ancils_mergebase42a1964 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants