Skip to content

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Nov 21, 2019

Covers changes from #3550 and #3556

NOTE: why this targets the 'launch_ancils' feature branch
We are still reserving the right to not announce ancillary variables in Iris 3.0, in which case this will be deferred from merging to master : see comment here.

@pp-mo pp-mo added this to the v3.0.0 milestone Nov 21, 2019
@abooton abooton changed the title Whatsnews relating to ancillary load + save. P3473: Whatsnews relating to ancillary load + save. Nov 26, 2019
@abooton abooton changed the title P3473: Whatsnews relating to ancillary load + save. PI3473: Whatsnews relating to ancillary load + save. Nov 26, 2019
@abooton abooton changed the title PI3473: Whatsnews relating to ancillary load + save. PI-3473: Whatsnews relating to ancillary load + save. Nov 26, 2019
@pp-mo pp-mo changed the base branch from master to launch_ancils November 29, 2019 16:40
@@ -0,0 +1,2 @@
* Fixed a bug where the attributes of cell methods in netcdf-CF files were discarded on
loading. They now appear on the CellMethod in the loaded cube.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should refer to cell measures/CellMeasure rather than cell methods/CellMethod.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!
I can't believe I'm still getting these names mixed up.
Will fix...

@stephenworsley stephenworsley self-assigned this Dec 12, 2019
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit db080fd into SciTools:launch_ancils Dec 17, 2019
abooton pushed a commit to abooton/iris that referenced this pull request Jun 5, 2020
* Whatsnews relating to ancillary load + save.
stephenworsley added a commit to stephenworsley/iris that referenced this pull request Aug 20, 2020
… launch_ancils

* 'launch_ancils' of https://github.com/SciTools/iris:
  Resolve conflicts with requirements/test.txt to update the imagehash pin to imagehash>=4.0 (SciTools#3735)
  PI:3358 (WIP) Ensure flags load/save without units (SciTools#3613)
  PI-3473 Rename "engine.provides" (SciTools#3590)
  PI-3473: Whatsnews relating to ancillary load + save. (SciTools#3557)
  PI-3473: Netcdf loading ancillary variables (SciTools#3556)

� Conflicts:
�	lib/iris/fileformats/netcdf.py
�	lib/iris/tests/unit/fileformats/netcdf/test__load_aux_factory.py
�	requirements/core.txt
@pp-mo pp-mo deleted the nc_ancil_whatsnew branch March 10, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants