Skip to content

PI-3473: Netcdf saving of ancillary variables #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 27, 2019
Merged

PI-3473: Netcdf saving of ancillary variables #3550

merged 8 commits into from
Nov 27, 2019

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Nov 18, 2019 •
edited
Loading

Saving ancillary variables, with some testcases based on CDL comparisons.

There is some unfinished business here where the tests might be improved,
if and when they can use other aspects of ancillary support :
UPDATE:
FIxed that.
Nearly good to go?

stickler-ci
stickler-ci reviewed Nov 18, 2019
View reviewed changes
@pp-mo pp-mo added this to the v3.0.0 milestone Nov 18, 2019
@pp-mo pp-mo self-assigned this Nov 18, 2019
@pp-mo pp-mo mentioned this pull request Nov 18, 2019
Merged
@pp-mo pp-mo force-pushed the ancil_save branch 2 times, most recently from c0c7158 to c67578f Compare November 19, 2019 18:11
@pp-mo pp-mo mentioned this pull request Nov 19, 2019
Merged
@pp-mo
Copy link
Member Author

pp-mo commented Nov 20, 2019

Hi @stephenworsley
Now rebased, should be GTG ! 🙏

@lbdreyer lbdreyer mentioned this pull request Nov 20, 2019
Closed
3 tasks
@pp-mo pp-mo mentioned this pull request Nov 21, 2019
Merged
stephenworsley
stephenworsley reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things I've noticed on my first pass through the code.

@stephenworsley stephenworsley self-assigned this Nov 26, 2019
@abooton abooton changed the title Netcdf saving of ancillary variables P.3473: Netcdf saving of ancillary variables Nov 26, 2019
@abooton abooton changed the title P.3473: Netcdf saving of ancillary variables PI3473: Netcdf saving of ancillary variables Nov 26, 2019
@abooton abooton changed the title PI3473: Netcdf saving of ancillary variables PI-3473: Netcdf saving of ancillary variables Nov 26, 2019
@pp-mo
Copy link
Member Author

pp-mo commented Nov 26, 2019

it probably ought to fail then, I think, complaining that the ancillary to be added is identical to one already there.

Rebased, and it did fail as predicted 👍
Now fixed.

stephenworsley
stephenworsley approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stephenworsley stephenworsley merged commit ba7756f into SciTools:master Nov 27, 2019
@pp-mo pp-mo deleted the ancil_save branch March 18, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephenworsley stephenworsley stephenworsley approved these changes

+1 more reviewer

@stickler-ci stickler-ci stickler-ci left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pp-mo pp-mo

@stephenworsley stephenworsley

Labels

None yet

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pp-mo @stickler-ci @stephenworsley @abooton