Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Oct 4, 2019

This is a minimal improvement to the problems identified in #3449 with the error + warning messages produced by iris.analysis.calculus._construct_midpoint_coord.

Frankly there's a lot more that's wrong with this + I almost wish I hadn't bothered :

  • the use of this private routine as a utility in the tests for another routine (_construct_delta_coord) is pretty horrible
  • the optional use of the 'circular' keyword is only used by the test code, not the main iris codebase : So it could, and should be much simpler !
  • the routine raises an error if called with circular=True when coord.circular does not exist, but it only emits a warning if coord.circular==False ((arrrrgh!))

@bjlittle
Copy link
Member

bjlittle commented Oct 4, 2019

omg 🤪

Some corners of iris are just distressing...

@bjlittle bjlittle merged commit f4b54ac into SciTools:master Oct 4, 2019
@QuLogic QuLogic added this to the v3.0.0 milestone Oct 6, 2019
@pp-mo pp-mo deleted the fix_message branch October 6, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants