Skip to content

Conversation

@lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented Oct 4, 2019

Whilst looking for deprecations that needed removing in the Iris 3 release, I came across what looks like something that shouldn't be deprecated?

I'm not sure! So I thought I would raise it.

It was originally a regular warning, but #1993 changed it to a deprecation warning

@lbdreyer lbdreyer added this to the v3.0.0 milestone Oct 4, 2019
@lbdreyer lbdreyer requested a review from pp-mo October 4, 2019 10:46
@bjlittle
Copy link
Member

bjlittle commented Oct 4, 2019

@pp-mo Unfortunately, your name is against #1993... care to cast your mind back to 2016 and comment, if humanly possible?

@pp-mo pp-mo self-assigned this Oct 4, 2019
@pp-mo
Copy link
Member

pp-mo commented Oct 4, 2019

Nice spot @lbdreyer !
I think this is a plain error from the original PR #1993.
Probably from an over-zealous use of search+replace.

I don't think this has anything to do with a deprecation.
It's also a pretty useless message, as-is, as it doesn't provide any context for what is wrong and only makes sense in reference to the API of a private internal routine.
:missing emoji for cupping brow with closed eyes:

@pp-mo pp-mo merged commit c832f58 into SciTools:master Oct 4, 2019
@lbdreyer lbdreyer deleted the wrong_deprecation branch June 23, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants