Move grib tests from iris into iris-grib

[lbdreyer]

Currently, there are some tests in iris that test grib handling but would preferably live in iris-grib. For instance #3469 has skipped 3 tests that fail due to needing changes in iris-grib that have not yet been released.

• tests/__init__.py: move TestGribMessage class (do this last!) @lbdreyer Remove TestGribMessage (ported to iris-grib) #3672 Port TestGribMessage from iris iris-grib#203
• tests/system_test.py @pp-mo Remove obsolete test. #3662
• tests/test_grib_load_translations.py @pp-mo Port test_grib_load_translations from iris iris-grib#191 Remove grib-specific test. #3663
• tests/test_grib_save.py @lbdreyer Port tests from iris/tests/integration/test_grib_save.py iris-grib#198 Remove iris/tests/integration/test_grib_save.py #3669
• tests/test_grib_save_rules.py @lbdreyer Port tests from iris/tests/test_grib_save_rules.py from iris iris-grib#195 Remove tests/grib_save_rules.py which has been moved to iris-grib #3666
• tests/test_uri_callback.py @lbdreyer Port tests from iris/tests/test_uri_ccallback.py iris-grib#194 Remove uri callback test which is moved to iris-grib #3665
• tests/integration/test_grib2.py @lbdreyer Port tests from iris/tests/integration/test_grib2.py iris-grib#192 Remove test_grib2 integration tests #3664
• tests/integration/test_grib_load.py @pp-mo Removed iris.tests.integration.test_grib_load and related CML files. #3670 Import tests from iris.test.integration.test_grib load iris-grib#200
• tests/integration/test_pickle.py @pp-mo Removed grib-specific test to iris-grib. #3671 Port pickling test from Iris. iris-grib#201
• tests/integration/format_interop/: leave for now?

[lbdreyer]

Related issues: #2860 #3477 #3375

[lbdreyer]

@pp-mo we could use this to track who is working on what

[pp-mo]

LINKS + notes (WIP editing as I go)

• tests/__init__.py: move TestGribMessage class (do this last!)
  • Iris usage:
    • tests/integration/grib2/test_grib2 : TestPDT11 TestGDT5
    • tests/test_grib_save : TestLoadSave
• tests/system_test.py system_test_grib_patch
  • Don't understand scope of this : where is the magic "patch" this is testing, is it just ancient + obsolete ?? -- see Remove obsolete test. #3662
• tests/test_grib_load_translations.py
  • Notes: OK should port simply. But is old + grib1-specific I think. The grib2 functionality in FakeGribMessage is no longer used see Port test_grib_load_translations from iris iris-grib#191 Remove grib-specific test. #3663
• tests/test_grib_save.py
  • Notes:
    • uses "iris.tests.TestGribMessage".
    • TestLoadSave look ok to me
      • some load, some save, possibly better to re-organise ?
    • TestCubeSave
      • some ancient stuff in here
• tests/test_grib_save_rules.py
  • Notes: three distinct components (testcase classes) in this testfile
    • Test_set_fixed_surfaces :
      • seems to belong in `iris_grib.tests.unit.save_rules.test_set_fixed_surfaces'
      • doesn't work in the same way : checks calls to mock(gribapi.grib_set), whereas iris-grib code checks content on an actual message. Prefer the existing way in iris-grib, may attempt to translate these. WIP
    • Test_phenomenon
      • seems to be replicating iris_grib.tests.unit.save_rules.test_set_discipline_and_parameter. ?Discard -- WIP
    • Test_type_of_statistical_processing
      • seems to belong in iris_grib.tests.unit.save_rules.test_statistical_cell_method.
        That isn't very cleam and neither is the save code itself, as not all templates go through statistical_method_code which they probably should do. Cases here are for 'minimum' + 'maximum' codes, neither of which are in existing tests. Could improve all this ? WIP
• tests/test_uri_callback.py test_grib_callback
• tests/integration/test_grib2.py @lbdreyer ...
• tests/integration/test_grib_load.py
• tests/integration/test_pickle.py TestGribMessage
• tests/integration/format_interop/: leave for now?

[pp-mo]

All dealt with, delivered in release v0.15.1