Import tests from iris.test.integration.test_grib load #200
Conversation
pp-mo
changed the title
iris_grib/tests/integration/load_convert/test_sample_file_loads.py
Outdated
Show resolved
Hide resolved
| _RESULTDIR_PREFIX + ("missing_values_grib2.cml",)) | ||
|
|
||
| @skip_irisgrib_fails | ||
| def test_y_fastest(self): |
There was a problem hiding this comment.
Why do you want to keep this test? We had already removed it from the iris repo: SciTools/iris#3632
There was a problem hiding this comment.
Ok, I hadn't spotted that when I did this.
| _RESULTDIR_PREFIX = ("integration", "load_convert", "sample_file_loads") | ||
|
|
||
|
|
||
| @tests.skip_data |
There was a problem hiding this comment.
We don't typically do this for iris-grib tests as, unlike iris, we always download the iris-test data.
That said, maybe it's a good idea to future-proof these tests, should we decide to copy what iris does.
There was a problem hiding this comment.
I did check for usage within iris-grib and there are lots of existing uses, so I thought it best to keep it.
There was a problem hiding this comment.
I see you are right, there are some that do use test.skip_data, but not all. We should try to be consistent with this and perhaps always include the @test.skip_data
…s.py Co-Authored-By: lbdreyer <[email protected]>
* Updated release notes. * Update version string. * Remove redundant test skipper: should have been in #200.
3 participants
Removed from iris : SciTools/iris#3670