Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

VecJacOperator #481

Merged
merged 13 commits into from
Oct 21, 2021
Merged

VecJacOperator #481

merged 13 commits into from
Oct 21, 2021

Conversation

avik-pal
Copy link
Member

No description provided.

@avik-pal avik-pal marked this pull request as draft October 12, 2021 21:34
@avik-pal avik-pal marked this pull request as ready for review October 12, 2021 21:47
@avik-pal
Copy link
Member Author

@ChrisRackauckas how do I prevent it from canceling the other tests if MOL fails?

@ChrisRackauckas
Copy link
Member

@YingboMa can you look at this failure? It's odd that this would come up.

@ChrisRackauckas
Copy link
Member

@valentinsulzer
Copy link
Contributor

Same error used to happen with MTK 6.4.7
MTK 6.4.9 fixed it
Now MTK 6.5.2 is broken again

@valentinsulzer
Copy link
Contributor

Has been an issue in the past with recognizing the rules for the spherical Laplacian operator

@ChrisRackauckas
Copy link
Member

@shashi can we figure out what happened to that rule application?

@valentinsulzer
Copy link
Contributor

central_deriv_rules_spherical = [Differential(s)(s^2*Differential(s)(u))/s^2 => central_deriv_spherical(II,j,k)

@shashi
Copy link

shashi commented Oct 18, 2021

central_deriv_rules_spherical = [Differential(s)(s^2*Differential(s)(u))/s^2 => central_deriv_spherical(II,j,k)

I don't see an error related to this in the CI failures...

@avik-pal
Copy link
Member Author

Will need JuliaDiff/SparseDiffTools.jl#158

@ChrisRackauckas
Copy link
Member

Requires it here too, and mention that in the docs

@ChrisRackauckas
Copy link
Member

Up the lower bound when bumping.

@avik-pal
Copy link
Member Author

@ChrisRackauckas I think it is good to go

@ChrisRackauckas ChrisRackauckas merged commit d63a253 into SciML:master Oct 21, 2021
@avik-pal avik-pal deleted the ap/vecjac branch October 21, 2021 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants