Skip to content

Add vecjac operators #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Add vecjac operators #158

merged 4 commits into from
Oct 20, 2021

Conversation

avik-pal
Copy link
Contributor

No description provided.

@ChrisRackauckas
Copy link
Member

We have Zygote under @requires right now for https://github.com/JuliaDiff/SparseDiffTools.jl/blob/master/src/differentiation/jaches_products_zygote.jl . Looking at the dependency list on JuliaHub and the stability of Zygote, I think we might want to keep it under Requires.jl for now.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #158 (7974f57) into master (867ccda) will decrease coverage by 3.61%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   83.72%   80.11%   -3.62%     
==========================================
  Files          12       13       +1     
  Lines         688      724      +36     
==========================================
+ Hits          576      580       +4     
- Misses        112      144      +32     
Impacted Files Coverage Δ
src/SparseDiffTools.jl 100.00% <ø> (ø)
src/differentiation/vecjac_products_zygote.jl 0.00% <0.00%> (ø)
src/differentiation/jaches_products.jl 97.87% <96.59%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867ccda...7974f57. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit 9c9e4d5 into JuliaDiff:master Oct 20, 2021
@avik-pal avik-pal deleted the ap/vecjac branch October 20, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants