Skip to content

'boolean java.lang.String.isEmpty()' on a null object reference on certain Android phones. #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2022
Merged

'boolean java.lang.String.isEmpty()' on a null object reference on certain Android phones. #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilReq.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ public void run() {

// find cached result if `key` property exists
String cacheKey = this.taskId;
String ext = this.options.appendExt.isEmpty() ? "" : "." + this.options.appendExt;
String ext = (this.options.appendExt == null || this.options.appendExt.isEmpty()) ? "" : "." + this.options.appendExt;

if (this.options.key != null) {
cacheKey = ReactNativeBlobUtilUtils.getMD5(this.options.key);
Expand Down Expand Up @@ -402,7 +402,7 @@ else if (value.equalsIgnoreCase("utf8"))

if (rawRequestBodyArray != null) {
requestType = RequestType.Form;
} else if (cType.isEmpty()) {
} else if (cType == null || cType.isEmpty()) {
if (!cType.equalsIgnoreCase("")) {
builder.header("Content-Type", "application/octet-stream");
}
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/ReactNativeBlobUtil/Utils/MimeType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class MimeType {
public static String getFullFileName(String name, String mimeType) {
// Prior to API 29, MimeType.BINARY_FILE has no file extension
String ext = MimeType.getExtensionFromMimeType(mimeType);
if (ext.isEmpty() || name.endsWith("." + "ext")) return name;
if ((ext == null || ext.isEmpty()) || name.endsWith("." + "ext")) return name;
else {
String fn = name + "." + ext;
if (fn.endsWith(".")) return StringUtils.stripEnd(fn, ".");
Expand Down