'boolean java.lang.String.isEmpty()' on a null object reference on certain Android phones. #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed that some Android phones were crashing when executing
ReactNativeBlobUtil.MediaCollection.copyToMediaStore.The crash log was showing
Attempt to invoke virtual method 'boolean java.lang.String.isEmpty()' on a null object reference.Unfortunately, none of the devices I have were crashing in this manner, and trying to debug on the few phones that the crash was observed on was impossible for us.
In this push, I am just adding a null check in all the places that perform
.isEmpty()check. I already tested the implementation and indeed, one of these.isEmpty()checks was responsible for the crash.Just in case if this will be of any help, one of the phones that were crashing is a Samsung Galaxy S8 running Android 8.