Skip to content

Conversation

@wep21
Copy link
Contributor

@wep21 wep21 commented Feb 6, 2025

No description provided.

@traversaro
Copy link
Member

It is not obvious to me if the ABI is changed or not in hardware_interface ( ros-controls/ros2_control@4.23.0...4.25.0 ). Can you include the needed changes as patches instead of bumping the version, so it is easier to check if they are ABI compatible?

$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:include/hardware_interface>
)
+target_link_libraries(mock_components PUBLIC hardware_interface)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21
Copy link
Contributor Author

wep21 commented Feb 6, 2025

@traversaro In the latest jazzy sync, ros2 control is updated from 4.23 to 4.25 and ros2 control maintainers release the master branch as jazzy which may break abi compatibility. How can we treat it?

@traversaro
Copy link
Member

@traversaro In the latest jazzy sync, ros2 control is updated from 4.23 to 4.25 and ros2 control maintainers release the master branch as jazzy which may break abi compatibility. How can we treat it?

If there is an update that breaks ABI, we can only do that as part of a full rebuild (that is essentially the robostack equivalent of the bloom sync).

@wep21
Copy link
Contributor Author

wep21 commented Feb 6, 2025

I see. I close this PR, once.

@wep21 wep21 closed this Feb 6, 2025
@wep21 wep21 deleted the update-hardware-interface branch February 6, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants