Add tests for retry logic based on response status code #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfunstonRAI
reviewed
Dec 18, 2023
jfunstonRAI
reviewed
Dec 18, 2023
| end | ||
|
|
||
| @testset "429: Too Many Requests" begin | ||
| # TODO: We probably should respect the Retry-After header, but we currently don't |
Contributor
There was a problem hiding this comment.
Is this something that HTTP.jl handles now? This might be a high priority thing for us to implement.
Member
There was a problem hiding this comment.
Okay, i think this is the only one to decide on... currently we're not retrying 429 at all, but arguably we should be (and if so, should be respecting the Retry-After header if set)
Member
There was a problem hiding this comment.
i'll leave this to a follow-up PR, if/when we have more info about if we need to support this at all and if it's best done inthe ObjectStore.jl repo (rather than the application itself)
jfunstonRAI
reviewed
Dec 18, 2023
jfunstonRAI
reviewed
Dec 18, 2023
jfunstonRAI
reviewed
Dec 18, 2023
nickrobinson251
force-pushed
the
td-even-more-exception-tests
branch
from
6de33c2 to
f980233
Compare
nickrobinson251
force-pushed
the
td-even-more-exception-tests
branch
from
5bf33d0 to
f7c1b93
Compare
None of the listed reasons seem like they could be transient https://learn.microsoft.com/en-us/rest/api/storageservices/blob-service-error-codes
nickrobinson251
force-pushed
the
td-even-more-exception-tests
branch
from
25679fe to
ed43a99
Compare
Member
|
@jfunstonRAI please can you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for retry logic based on Azure docs:
Current behaviour is to retry 5** error codes (server errors) and not retry 4** error codes (client errors).
For RAICode, we use up to 15 minutes of retries so we need to be picky about when retrying makes sense... so only 5** codes is probably a good starting point. But we should consider (in future) if we should retry 429 error code (throttling error) and respecting Retry-After header if set.